Bug 178946 - [Viewers] ColumnViewerEditorDeactivationEvent should hold informations why the editor is deactivated
Summary: [Viewers] ColumnViewerEditorDeactivationEvent should hold informations why th...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-03-23 03:38 EDT by Thomas Schindl CLA
Modified: 2007-08-10 02:16 EDT (History)
1 user (show)

See Also:

Attachments
Introduce the new API (3.00 KB, patch)
2007-07-20 05:11 EDT, Thomas Schindl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2007-03-23 03:38:22 EDT 
I'd propose 2 constants:
- EDITOR_CANCLED
- EDITOR_SAVED

And one instance field:
- actionType
Comment 1 Boris Bokowski CLA 2007-03-23 08:25:11 EDT 
I wish we had used one event type :-(
Comment 2 Thomas Schindl CLA 2007-03-23 08:29:17 EDT 
This wouldn't have solved this issue we simply forgot about this. I still convinced that using a different event type makes sense because there are so many differences between those 2 events.
Comment 3 Boris Bokowski CLA 2007-03-23 08:43:06 EDT 
Yes, but we could have re-used some of the fields. SWT's Event.java has all kinds of fields, and not all apply to all event types.
Comment 4 Thomas Schindl CLA 2007-07-20 05:11:35 EDT 
Created attachment 74242 [details]
Introduce the new API
Comment 5 Thomas Schindl CLA 2007-07-20 05:12:23 EDT 
Boris, any comments about the new API?
Comment 6 Boris Bokowski CLA 2007-07-23 11:13:04 EDT 
+1
Comment 7 Thomas Schindl CLA 2007-07-26 16:34:33 EDT 
Release to CVS-HEAD >= 20070726
Comment 8 Thomas Schindl CLA 2007-08-10 02:16:36 EDT 
by code introspection in I20070809