Community
Participate
Working Groups
I20070320-0010 - In the Help window, open Workbench User Guide > What's new - Click on the Platform Changes link in the document - Sync with toc Bug: It thinks the doc isn't in the table of contents because we navigated to an anchor in a document. This seems to work ok in the help view, probably because it tries stripping the anchor part of the url if it can't find the document with the anchor.
Adam, could you look at this? It would be nice to get this into Eclipse 3.3 - it seems to happen fairly frequently.
I've seen this a few times myself just in the last week. We should fix for 3.3 if possible, I expect the fix to be low risk.
Created attachment 67747 [details] fixed This patch simply removes any anchor from the link before finding the toc path. I originally tried searching with the anchor and then without (to provide support for toc entries with anchors in the URL), but that proved to be a much more complex change. If that functionality is desired it should be addressed in 3.4.
Created attachment 67837 [details] Test cases I just created a simple test case, which is a TOC containing three pages containing anchors, Page1 and Page2#A2 are in the TOC, Page 3 is not in the TOC. Before your patch Show in TOC worked for Page1 and Page2#A2, after the patch it worked for Page1, Page1#A1, Page1#A2 and Page1#A3, but not for Page2#A2. While I don't think use of anchors in the TOC will be common it would be better if all of the cases that used to work still worked. Can you take a look at this again to see if it is possible to get Page2#A2 working again, or better still get all of the Page2 cases working.
Created attachment 67847 [details] fixed properly I figured out a simple way to achieve the functionality I was originally hoping for. This patch should provide support for all cases regarding anchors including the one discussed in comment #3. The toc will be searched with the anchor text and if a reference is not found it will be searched again without.
+1 from me, requesting approval from Curtis also. My testing indicates that the Webapp now matches the Help View as far as which cases work for Show in TOC.
Patch looks safe.
Patch committed to HEAD.
Verified in I20070608-1718.
