Bug 178280 - [JFace] AbstractColumnLayout updating of column sizes not working correct on gtk
Summary: [JFace] AbstractColumnLayout updating of column sizes not working correct on gtk
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 178757
Blocks:
  Show dependency tree
 
Reported: 2007-03-20 10:41 EDT by Thomas Schindl CLA
Modified: 2007-05-03 17:58 EDT (History)
3 users (show)

See Also:


Attachments
Test-Table to see whether Resize is happening on last column (2.21 KB, patch)
2007-03-21 07:38 EDT, Thomas Schindl CLA
no flags Details | Diff
Patch to identify intermediate events on GTK (3.93 KB, patch)
2007-03-21 07:39 EDT, Thomas Schindl CLA
no flags Details | Diff
Proposed patch to make layout's work on GTK (4.90 KB, patch)
2007-04-10 07:13 EDT, Thomas Schindl CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2007-03-20 10:41:03 EDT
The problem is that we get an resize event for the last column when we resize the control this is not the desired behaviour
Comment 1 Boris Bokowski CLA 2007-03-20 11:38:55 EDT
Can we fix this for M6?
Comment 2 Thomas Schindl CLA 2007-03-20 14:03:22 EDT
Boris I'm looking into this tomorrow when I'm back in company and have a Linux box available. I think the fix is trivial by not updating the LayoutData if the event.widget is the last column but I need a box to test.
Comment 3 Thomas Schindl CLA 2007-03-21 07:36:00 EDT
Ok. The problem we are facing is that on Linux-Gtk:
1. We get an Resize-Event for the last table column when we resize the control
   (this can be worked around by checking if the event.widget is the last column). 
   This doesn't happen on MacOSX

2. We get intermediate resize event when we are resizing the table this is somehow strange and I can't say at the moment why this is happening because we are the only one assigning sizes to table-columns and are setting a flag so that the event is not processed. Maybe the control-adapter is called asynchronosly on GTK, maybe someone from SWT can shade some light into this.
   This doesn't happen on MacOSX
Comment 4 Thomas Schindl CLA 2007-03-21 07:38:03 EDT
Created attachment 61524 [details]
Test-Table to see whether Resize is happening on last column

Can so one try and post output on Win32 platform?
Comment 5 Thomas Schindl CLA 2007-03-21 07:39:13 EDT
Created attachment 61525 [details]
Patch to identify intermediate events on GTK

Can someone run on Win32 and post the output
Comment 6 Thomas Schindl CLA 2007-03-21 07:41:59 EDT
Output in Linux-GTK for TableTest:
----------8<----------
BEFORE OPEN
EVENT TRIGGERED COL 1
EVENT TRIGGERED COL 2
AFTER OPEN
EVENT TRIGGERED COL 2
EVENT TRIGGERED COL 2
EVENT TRIGGERED COL 2
EVENT TRIGGERED COL 2
----------8<----------

Output for TableLayout-Snippet
----------8<----------
SETTING WIDTH START
SETTING WIDTH END
SETTING NEW DATA: 636
SETTING WIDTH START
SETTING WIDTH END
SETTING NEW DATA: 639
SETTING WIDTH START
SETTING WIDTH END
SETTING WIDTH START
SETTING WIDTH END
SETTING WIDTH START
SETTING WIDTH END
SETTING NEW DATA: 636
SETTING WIDTH START
SETTING WIDTH END
SETTING WIDTH START
SETTING WIDTH END
SETTING NEW DATA: 629
SETTING WIDTH START
SETTING WIDTH END
SETTING WIDTH START
SETTING WIDTH END
SETTING NEW DATA: 596
----------8<----------
Comment 7 Boris Bokowski CLA 2007-03-21 08:16:32 EDT
TableTest on Windows XP:
----
BEFORE OPEN
AFTER OPEN
----

Snippet016TableLayout on Windows XP:
----
SETTING WIDTH START
SETTING WIDTH END
SETTING WIDTH START
SETTING WIDTH END
----
Comment 8 Boris Bokowski CLA 2007-03-21 08:23:54 EDT
I just started the snippets - was I supposed to resize anything?
Comment 9 Thomas Schindl CLA 2007-04-10 07:13:52 EDT
Created attachment 63338 [details]
Proposed patch to make layout's work on GTK

We need to test on OSX and Win32
Comment 10 Thomas Schindl CLA 2007-04-10 11:59:09 EDT
tested patch on MacOSX and it works
Comment 11 Thomas Schindl CLA 2007-04-12 14:08:45 EDT
Tested on all major platforms and released > 20070412
Comment 12 Thomas Schindl CLA 2007-05-03 17:58:37 EDT
Verified in I20070502-1800 by code inspection