Bug 178233 - Unnecessary checkbox for Commit Wizard
Summary: Unnecessary checkbox for Commit Wizard
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-03-20 07:36 EDT by Tomasz Zarna CLA
Modified: 2007-06-05 15:14 EDT (History)
0 users

See Also:

Attachments
Screenshot with the last page of the wizard (10.09 KB, image/png)
2007-03-20 07:37 EDT, Tomasz Zarna CLA 		no flags Details
Patch (2.39 KB, patch)
2007-04-16 05:15 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylar/context/zip (4.39 KB, application/octet-stream)
2007-04-16 05:15 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2007-03-20 07:36:20 EDT 
Build ID: I20070320-0010

Steps To Reproduce:
1. Synchronize a project with repository
2. Disconnect the project
3. Share it with the same repository location

On the last page of the "Share Project" wizard there is a message saying that all resource are in-sync (no surprise here). As a consequence of that IMO there is no need to showing "Launch Commit Wizard" checkbox. It should be either hidden or disabled.


More information:
Comment 1 Tomasz Zarna CLA 2007-03-20 07:37:06 EDT 
Created attachment 61372 [details]
Screenshot with the last page of the wizard
Comment 2 Tomasz Zarna CLA 2007-04-16 05:15:23 EDT 
Created attachment 63879 [details]
Patch

Fix: the checkbox is placed on the wizard's page only when there differences detected. Two separate composites are used: one with a compare part and the checkbox and the second one with a label only.
Comment 3 Tomasz Zarna CLA 2007-04-16 05:15:25 EDT 
Created attachment 63880 [details]
mylar/context/zip
Comment 4 Michael Valenta CLA 2007-04-16 10:52:08 EDT 
Patch released to HEAD
Comment 5 Tomasz Zarna CLA 2007-04-25 06:07:39 EDT 
Verified in I20070424-0930.