Bug 17782 - [ExternalTools] Custom tasks not checked for validity
Summary: [ExternalTools] Custom tasks not checked for validity
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords: core, ui
Depends on:
Blocks:
 
Reported: 2002-05-24 14:35 EDT by Adam Schlegel CLA
Modified: 2002-12-09 18:19 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Schlegel CLA 2002-05-24 14:35:29 EDT
 
Comment 1 Adam Schlegel CLA 2002-05-24 14:43:16 EDT
When adding a custom task/type to Eclipse's Ant via the properties page, the  
page does not check to see if the class that the user gives is actually on 
Ant's classpath. If the class is not foud, then Ant will report an error the 
first time it is run.

Since the dialog that the user types the classname into requires that a jar 
file containing the class be specified, it would be better to browse the jar 
file and select the class, rather than type in the class name. This would 
prevent invalid classnames from being entered.
Comment 2 Simon Arsenault CLA 2002-05-29 13:16:05 EDT
At the very least, we should validate the class name against the jar file. 
Providing a list to select from is a nice to have for release 2.0
Comment 3 Darin Swanson CLA 2002-10-24 10:57:25 EDT
To make this even better we should also check the validity of the task a la 
org.apache.tools.ant.Project#checkTaskClass(Class)
Comment 4 Darin Swanson CLA 2002-11-12 20:11:06 EST
Moving to M4
Comment 5 Darin Swanson CLA 2002-12-05 12:00:50 EST
Reworked.
You now view the contents of the JAR and select the class file.
Comment 6 Darin Swanson CLA 2002-12-05 12:01:14 EST
Please verify (Jared).
Comment 7 Jared Burns CLA 2002-12-09 18:19:30 EST
Verified.