Bug 177356 - [Forms] Track focus between header and page folder in SharedHeaderFormEditor
Summary: [Forms] Track focus between header and page folder in SharedHeaderFormEditor
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-14 11:42 EDT by Christof Marti CLA
Modified: 2007-04-25 13:59 EDT (History)
3 users (show)

See Also:


Attachments
Proposed solution (4.13 KB, patch)
2007-03-14 11:45 EDT, Christof Marti CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Marti CLA 2007-03-14 11:42:36 EDT
3.3M5

The SharedHeaderFormEditor could track if the header or the page folder had focus and restore that focus on setFocus().
Comment 1 Christof Marti CLA 2007-03-14 11:45:33 EDT
Created attachment 60815 [details]
Proposed solution

Proposed solution that includes a fix for bug 177331.
Comment 2 Philipe Mulet CLA 2007-04-03 11:50:55 EDT
Can this be fixed for 3.3M7 ?
Comment 3 Chris Goldthorpe CLA 2007-04-03 12:44:48 EDT
I'm not sure yet if this will get fixed for M7, I'm currently working on identifying the top priority defects so that those can be fixed first. Can you elaborate on why this is important to fix so I can put it in the appropriate place in my bug queue.
Comment 4 Christof Marti CLA 2007-04-04 09:06:22 EDT
Every extender of SharedHeaderFormEditor will eventually need a solution to the focus tracking and keybinding (bug 177331) problems. Subclasses can solve the keybinding issue only by using the deprecated IKeyBindingService and experimental INestable. That is, there is a workaround that might break in the future.
Comment 5 Chris Goldthorpe CLA 2007-04-05 13:59:58 EDT
I'll take a look at this for M7
Comment 6 Chris Goldthorpe CLA 2007-04-16 19:02:00 EDT
Can you explain more what you mean by tracking focus between the header and page?
Comment 7 Christof Marti CLA 2007-04-19 18:03:44 EDT
In order for SharedHeaderFormEditor#setFocus() to decide where to pass the call, the header or the active page, it needs a way to determine which of both had the focus last. By "focus tracking" I mean listening on the header and page folder for activation events and remembering where the last event came from.
Comment 8 Erich Gamma CLA 2007-04-25 10:14:21 EDT
This is a bug that Jazz would like to have fixed for 3.3. 
Comment 9 Curtis d'Entremont CLA 2007-04-25 13:59:22 EDT
Patch applied. Thanks again Christof.