Bug 17733 - [View Mgmt] Leak: ViewPanes still around after closing
Summary: [View Mgmt] Leak: ViewPanes still around after closing
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2002-05-24 12:02 EDT by Adam Kiezun CLA
Modified: 2003-02-03 14:54 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-05-24 12:02:04 EDT
F1
ViewPanes still stack around after you close them

scenario:
close the navigator

the ViewPane instance that had the navigator is still there
(sometimes it is reused, sometimes not 
(like in the case of PackageExpolorer) - i could not figure that out)

they should be removed and if they cannot be, then
they should at least free their memory od dispose() (i.e. nullify the fields)
Comment 1 Nick Edgar CLA 2002-05-29 10:27:07 EDT
Do you have the Navigator open in another perspective in the same window?
Comment 2 Adam Kiezun CLA 2002-05-29 12:32:06 EDT
sorry, don't remember now 
but i don't think so
Comment 3 Nick Edgar CLA 2002-05-29 12:53:42 EDT
Kevin, one leak test we should do on today's build is:
- close all perspectives
- open Resource perspective
- check number of instances of ResourceNavigator (should be 1)
- close ResourceNavigator
- check number of instances of ResourceNavigator (should be 0)
- reopen ResourceNavigator
- check number of instances of ResourceNavigator (should be 1)

Comment 4 Eduardo Pereira CLA 2002-05-30 11:39:50 EDT
Added println(s) to Resourcenavigator and we are calling dispose when the view 
is closed in all perspectives.
Comment 5 Eduardo Pereira CLA 2002-05-31 17:22:14 EDT
Tested it using Optimizeit.
The Navigator had a reference to it in some cases.

Fix PartTabFolder. Released in the HEAD stream.
Comment 6 Eduardo Pereira CLA 2002-06-05 13:58:38 EDT
Reopening. 
Backing out the fix in PartTabFolder. It has side efects.
See bug 18929.
Comment 7 Nick Edgar CLA 2002-06-05 14:09:39 EDT
The leak is less critical than the layout problems.
This area is too risky to change at this point for 2.0.
Comment 8 Eduardo Pereira CLA 2002-06-05 14:13:50 EDT
Can we resolve it as LATER?
Comment 9 Nick Edgar CLA 2002-06-05 14:28:22 EDT
Sure.
Comment 10 Kevin Haaland CLA 2002-06-05 14:58:44 EDT
What is leaking?
Comment 11 Eduardo Pereira CLA 2002-06-05 15:05:56 EDT
The View itself. The method dispose gets called but we keep one reference to 
the view which may be eventualy released.
Comment 12 Randy Giffen CLA 2002-08-12 10:36:14 EDT
Reopened for investigation
Comment 13 Eduardo Pereira CLA 2003-02-03 14:54:43 EST
Fix is already released in the 2.1 stream.