Community
Participate
Working Groups
ItemsListSeparator is currently protected and is in use by the resource dialog. We should not expose the existance of a seperator outside of the dialog itself and we should just not refer to it at all. Markus how did you get around the issue of someone selecting the seperator? Krysztof why do you need to check if the selection is a ItemsListSeparator in if (element instanceof ItemsListSeparator) { return true; } else if (element instanceof IResource) { return resourceWorkingSetFilter.select(viewer, parentElement, element); } return false;
Looking at the code myself I think that the reference to the seperator is entirely unneccessary as the resource filter handles it all. I will attach a patch that removes this reference and makes the seperator internal.
Created attachment 60601 [details] Patch that removes the reference to the seperator
This patch is obsolete if you release the fix for bug 172844. I suggest to mark as dup.
Actually it isn't - this patch handles the adaptable case in CustomWorkingSetFilter which Bug 172844 doesn't. But they can be amalgamated
Fixed with the patch for Bug 172844