Bug 177046 - ItemsListSeparator should not be referenced outside of FilteredResourcesSelectionDialog
Summary: ItemsListSeparator should not be referenced outside of FilteredResourcesSelec...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Krzysztof Michalski CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on: 172844
Blocks:
  Show dependency tree
 
Reported: 2007-03-12 14:58 EDT by Tod Creasey CLA
Modified: 2007-03-22 10:28 EDT (History)
2 users (show)

See Also:


Attachments
Patch that removes the reference to the seperator (1.83 KB, patch)
2007-03-12 15:21 EDT, Tod Creasey CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2007-03-12 14:58:16 EDT
ItemsListSeparator is currently protected and is in use by the resource dialog.

We should not expose the existance of a seperator outside of the dialog itself and we should just not refer to it at all.

Markus how did you get around the issue of someone selecting the seperator?

Krysztof why do you need to check if the selection is a ItemsListSeparator in 

	if (element instanceof ItemsListSeparator) {
				return true;
			} else if (element instanceof IResource) {
				return resourceWorkingSetFilter.select(viewer, parentElement,
						element);
			}

			return false;
Comment 1 Tod Creasey CLA 2007-03-12 15:19:23 EDT
Looking at the code myself I think that the reference to the seperator is entirely  unneccessary as the resource filter handles it all.

I will attach a patch that removes this reference and makes the seperator internal.
Comment 2 Tod Creasey CLA 2007-03-12 15:21:59 EDT
Created attachment 60601 [details]
Patch that removes the reference to the seperator
Comment 3 Markus Keller CLA 2007-03-13 05:29:48 EDT
This patch is obsolete if you release the fix for bug 172844. I suggest to mark as dup.
Comment 4 Tod Creasey CLA 2007-03-13 09:30:58 EDT
Actually it isn't - this patch handles the adaptable case in CustomWorkingSetFilter which Bug 172844 doesn't. But they can be amalgamated
Comment 5 Tod Creasey CLA 2007-03-13 10:59:57 EDT
Fixed with the patch for Bug 172844