Bug 176356 - setModified(false) is not called after a succesful save() on the StoreResource
Summary: setModified(false) is not called after a succesful save() on the StoreResource
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Teneo (show other bugs)
Version: unspecified   Edit
Hardware: All Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Martin Taal CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-03-05 05:57 EST by Benjamin Cabé CLA
Modified: 2008-05-27 19:19 EDT (History)
0 users

See Also:

Attachments
Patch against R0_7_0_maintenance branch (677 bytes, patch)
2007-03-05 05:59 EST, Benjamin Cabé CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2007-03-05 05:57:50 EST 
When StoreResource::save() is called and no error has been detected, then modifiedEobjects, removedEObjects,... and so on lists are cleared, but setModified(false) isn't called, whereas it's the default behaviour in every Resource impls (and, of course, in ResourceImpl, superclass of StoreResource)
Comment 1 Benjamin Cabé CLA 2007-03-05 05:59:58 EST 
Created attachment 60252 [details]
Patch against R0_7_0_maintenance branch

I didn't switched to the EMF 2.3 Teneo version so here is a patch for the R0.7 maintenance branch (would have been exactly the same for HEAD though...)
Comment 2 Martin Taal CLA 2007-03-05 13:16:27 EST 
Hi Benjamin,
Thanks for providing this patch. I have applied it in cvs. Will be in the next release.

gr. Martin
Comment 3 Benjamin Cabé CLA 2007-03-06 04:30:53 EST 
Thanks for being so reactive ! :)
Comment 4 Martin Taal CLA 2007-03-09 17:40:04 EST 
Has been solved in builds M200703091332 and I200703081604.
Comment 5 Nick Boldt CLA 2008-01-28 16:56:54 EST 
Move to verified as per bug 206558.