Comment 1 Tod Creasey 2007-02-21 15:39:17 EST

Created attachment 59514 [details]
Last patch from 172005

Comment 2 Tod Creasey 2007-02-21 15:48:47 EST

This looks like it is the patch for several bugs at once (i.e. it handles the pluggable seperator case). 

Please attach a patch for this specific issue and then I can look at it in isolation. There are API changes here that will need PMC approval so I need to look at the bugs they are associated with individually.

Comment 3 Krzysztof Michalski 2007-02-22 04:34:24 EST

Created attachment 59550 [details]
Proposition of changes

Generaly i removed multiple jobs to searching elements.
I create FilterJob which instance is reused to searching elements depend on filters. This eliminate all problems with concurrnt modifications. Now we have one job to searching elements and one ui job to refresh.

Comment 4 Tod Creasey 2007-02-22 12:30:26 EST

Some comments:

stop() is not neccessary if it just calls cancel in FilterJob

You can return a Status.OK_STATUS for OK

You are catching OperationCancelled and then making a cancelled status. As we are not showing the user anything you don't need to

try to use a finally block so that you can always call monitor.done()

filterJob is never null so the null check is not required


I have made this changes and submitted the patch