Bug 174908 - [Contributions] Leakage: PluginActionContributionItem not being removed as activity manager listener
Summary: [Contributions] Leakage: PluginActionContributionItem not being removed as ac...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 178870 181060 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-02-20 21:30 EST by Darin Swanson CLA
Modified: 2007-04-24 07:52 EDT (History)
5 users (show)

See Also:

Attachments
PartSite dispose v01 (1.23 KB, patch)
2007-03-22 20:29 EDT, Paul Webster CLA 		no flags Details | Diff
PopupMenu leak protection (4.75 KB, patch)
2007-03-27 14:32 EDT, Paul Webster CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2007-02-20 21:30:27 EST 
Eclipse 3.3M5

Tested in the resource perspective (only perspective open)
Opened the Project Explorer
Right click on a Java project to realize the context menu
Close the project explorer

Each time I repeat this I am seeing leakage which appears to be rooted in the PluginContributionItem(s) that have been added as activity listeners not being removed as listeners.

Note that the problem is not limited to the Project Explorer from my testing.
Comment 1 Paul Webster CLA 2007-03-22 20:27:41 EDT 
see also bug 178870
PW
Comment 2 Paul Webster CLA 2007-03-22 20:29:04 EDT 
Created attachment 61774 [details]
PartSite dispose v01

This is promising, but doesn't go far enough.  It looks like popup submenu items (like Team) are leaked on every popup.

PW
Comment 3 Paul Webster CLA 2007-03-27 14:32:32 EDT 
Created attachment 62136 [details]
PopupMenu leak protection

The menu extenders cache the plugin action contributions items.  When they remove all items in preperation for the next show, they dispose of the items.

The part dispose still disposes all of the context menu managers.

PW
Comment 4 Paul Webster CLA 2007-03-30 14:36:44 EDT 
Released in HEAD >20070330
PW
Comment 5 Paul Webster CLA 2007-04-09 19:29:13 EDT 
*** Bug 178870 has been marked as a duplicate of this bug. ***
Comment 6 Dani Megert CLA 2007-04-11 08:12:39 EDT 
Verified in I20070410-1043
Comment 7 Paul Webster CLA 2007-04-24 07:52:46 EDT 
*** Bug 181060 has been marked as a duplicate of this bug. ***