Bug 174737 - [IDE] New Plug-in Project wizard status handling is inconsistent
Summary: [IDE] New Plug-in Project wizard status handling is inconsistent
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 186752
Blocks:
  Show dependency tree
 
Reported: 2007-02-20 02:18 EST by Gunnar Wagenknecht CLA
Modified: 2007-08-24 04:33 EDT (History)
2 users (show)

See Also:

Attachments
Patch attachement (1.16 KB, patch)
2007-03-07 06:23 EST, Jakub Jurkiewicz CLA 		no flags Details | Diff
Updated patch (2.09 KB, patch)
2007-05-02 13:35 EDT, Tod Creasey CLA 		no flags Details | Diff
Illustrates the issue from the comment 8 (88.84 KB, image/jpeg)
2007-05-10 19:39 EDT, Szymon Brandys CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2007-02-20 02:18:42 EST 
3.3 M5

1. New -> Project...
2. Select "Plug-in Project" and click "Next"
=> Status: "Project name must be specified"

3. Uncheck "Use default location"
=> Status: [ERROR] "Project contents directory must be specified"

4. Enter project name "abc"
=> Status: OK, "Next" button enabled

The status is wrong. It should fall back to error "Project contents directory must be specified" with the "Next" button disabled.
Comment 1 Wassim Melhem CLA 2007-02-20 02:38:49 EST 
Problem is in WizardNewProjectCreationPage, which PDE subclasses.

Same thing happens in the Simple Project creation wizard, for example.
Comment 2 Jakub Jurkiewicz CLA 2007-03-07 06:23:07 EST 
Created attachment 60365 [details]
Patch attachement

I attached a patch. Please verify.
Comment 3 Wassim Melhem CLA 2007-04-23 14:53:06 EDT 
As demonstrated by the patch, it's an IDE issue.
Comment 4 Tod Creasey CLA 2007-04-25 12:59:57 EDT 
I'll review for 3.3
Comment 5 Tod Creasey CLA 2007-05-02 13:35:56 EDT 
Created attachment 65655 [details]
Updated patch

This is more effecient as checkValidLocation also does validateProjectLocationUR I

 if (!locationArea.isDefault()) {
        	String validLocationMessage = locationArea.checkValidLocation();
        	if (validLocationMessage != null) { //there is no destination location given
        		setErrorMessage(validLocationMessage);
        		return false;
        	}
        }
Comment 6 Tod Creasey CLA 2007-05-07 15:52:50 EDT 
Szymon could you please check this patch and give your +1 if acceptable?
Comment 7 Tod Creasey CLA 2007-05-10 15:48:28 EDT 
Szymon?
Comment 8 Szymon Brandys CLA 2007-05-10 19:36:27 EDT 
It seems that locationArea.checkValidLocation() doesn't work well. When I try
to put there location like "as", I can press "Next" but then after pressing "Finish" I have an error dialog
that the location is wrong. Also the message in this dialog is strange.
Comment 9 Szymon Brandys CLA 2007-05-10 19:39:27 EDT 
Created attachment 66790 [details]
Illustrates the issue from the comment 8
Comment 10 Jakub Jurkiewicz CLA 2007-05-14 03:22:06 EDT 
Szymon, shouldn't it be reported as a separate bug? The patch attached here doesn't cause this problem with location - it was already in the code.
I will try to investigate this.
Comment 11 Jakub Jurkiewicz CLA 2007-05-14 04:51:18 EDT 
After the discussion with Szymon, I created new bug 186752 and put it as blocker for this one.
Comment 12 Tod Creasey CLA 2007-05-14 08:13:19 EDT 
Jakub I don't think this blocks it but thanks for the reference (we could really do with a related to field). Szymon except for the issues you found in Bug 186752 is this a +1 from you?
Comment 13 Szymon Brandys CLA 2007-05-14 08:58:57 EDT 
yes. +1 from me.
Comment 14 Tod Creasey CLA 2007-05-14 16:43:54 EDT 
Fixed released for build >20070514
Comment 15 Tod Creasey CLA 2007-05-16 10:20:32 EDT 
Verified in 20070515-0100