Bug 174658 - [context] support context preview without requiring task activation
Summary: [context] support context preview without requiring task activation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6   Edit
Assignee: Sam Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy, plan
: 178921 (view as bug list)
Depends on:
Blocks: 197168
  Show dependency tree
 
Reported: 2007-02-19 12:02 EST by Mik Kersten CLA
Modified: 2011-05-19 10:59 EDT (History)
5 users (show)

See Also:


Attachments
patch for previewing (not editing) context (24.29 KB, patch)
2011-02-23 15:55 EST, Sam Davis CLA
no flags Details | Diff
mylyn/context/zip (15.87 KB, application/octet-stream)
2011-02-23 15:55 EST, Sam Davis CLA
no flags Details
3.6.patch (24.33 KB, patch)
2011-05-05 14:47 EDT, Sam Davis CLA
shawn.minto: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mik Kersten CLA 2007-02-19 12:02:32 EST
Currently only the context for the active task can be previewed and edited.  Task activation should not be required.
Comment 1 Eugene Kuleshov CLA 2007-02-19 14:39:42 EST
It would be also neat to be able to preview (or maybe even compare) contexts attached to the task. Perhaps Context tab would be opened in a separate editor.
Comment 2 Mik Kersten CLA 2007-02-19 23:09:04 EST
I have a few actions in mind to provide with this infrastructure along these lines (e.g. compare, merge).  I prototyped this stuff way back and so we already have the infrastructure for loading multiple contexts in order to support this.  But we need a driving use case.  Currently on top of my list is retrieving a repository context when a local task context is already present, highlight difference, then allow merge.
Comment 3 Eugene Kuleshov CLA 2007-02-20 11:37:23 EST
How about comparing two contexts attached to the same task? Without retrievning or merging anything.
Comment 4 Mik Kersten CLA 2007-02-20 18:08:35 EST
Yes, the UI additions to support that should not be that complicated.  I'm thinking that below the current "Actions" table we have a table of all the contexts, including the local one, and any number of those can be loaded (e.g. via check box).  Each could get a different highlight color.  

If we want to discuss this further we should move the discussion to bug 138544.
Comment 5 Mik Kersten CLA 2007-03-26 21:04:05 EDT
*** Bug 178921 has been marked as a duplicate of this bug. ***
Comment 6 Eugene Kuleshov CLA 2007-03-30 12:35:00 EDT
Mik, what is the target for this one?

It is quite ugly right now. Say I opened a task editor, i.e. from the change sets or history view. Then I retrieved context and wanted to see it. So, I have to activate task. But task editor is closed upon task activation, and many other editors (that I don't really care about) are opened instead...
Comment 7 Mik Kersten CLA 2007-03-30 14:44:49 EDT
I may look at it today, definitely needs to be done for 2.0.
Comment 8 Mik Kersten CLA 2007-06-21 16:00:14 EDT
 (In reply to comment #7)
> I may look at it today, definitely needs to be done for 2.0.

Unfortunately I need to go back on the above statement since this will require a proper design and should not be hacked in (Mylyn currently has no notion of anything other than the active task in terms of UI filtering).  That said this should be doable without changing API.  While it would be nice to have, this is not a critical feature since there is a clear work-around. Also 
Comment 9 Mik Kersten CLA 2008-05-27 12:14:05 EDT
This is unlikely to make it into 3.0, but will take a look.
Comment 10 Mik Kersten CLA 2008-06-05 13:50:20 EDT
Tentatively scheduling for 3.1 for planning purposes.
Comment 11 Sam Davis CLA 2011-02-23 15:55:40 EST
Created attachment 189639 [details]
patch for previewing (not editing) context

Thanks Shawn for helping me get started on this.
Comment 12 Sam Davis CLA 2011-02-23 15:55:42 EST
Created attachment 189640 [details]
mylyn/context/zip
Comment 13 Steffen Pingel CLA 2011-02-23 16:01:14 EST
Great! We are past the contribution deadline for 3.5 but we should consider this for 3.6
Comment 14 Shawn Minto CLA 2011-02-24 13:19:23 EST
Yes, we should look at this for 3.6 for sure!  This has been needed for a while.
Comment 15 Sam Davis CLA 2011-02-24 14:12:59 EST
I've been bootstrapping something close to this patch for quite a while now and it's very useful - I use it all the time.
Comment 16 Shawn Minto CLA 2011-05-05 14:13:38 EDT
Sam, I was hoping that we might have a chance of getting this in for 3.6, but it doesn't seem to apply cleanly.  Think that you can cut a new patch so that I can review and if it seems good we can get a CQ filed for this?
Comment 17 Sam Davis CLA 2011-05-05 14:47:20 EDT
Created attachment 194860 [details]
3.6.patch

Shawn, here's a patch for 3.6.
Comment 18 Shawn Minto CLA 2011-05-06 13:30:13 EDT
This looks awesome!  Steffen, can we work on getting a CQ filed for this (this will be my first so it would be good to learn what to do)
Comment 19 Shawn Minto CLA 2011-05-06 17:19:39 EDT
The patch is actually shorter than I thought so I have applied it.  Leaving open for now to collect any feedback on this.
Comment 20 Sam Davis CLA 2011-05-06 17:38:26 EDT
I have feedback :D Now that you can look at contexts for a task that isn't active, it would be useful for show in package explorer to work.
Comment 21 Steffen Pingel CLA 2011-05-06 19:02:11 EDT
(In reply to comment #20)
> I have feedback :D Now that you can look at contexts for a task that isn't
> active, it would be useful for show in package explorer to work.

Sounds like a good idea. Please open a separate bug for that.
Comment 22 Steffen Pingel CLA 2011-05-19 10:59:17 EDT
I'm marking this bug resolved in order to include it in the IP log. Shawn, please file separate bugs for any outstanding items.

Thanks for the great contribution, Sam!