Bug 174059 - Bug editor does not highlight changed attributes
Summary: Bug editor does not highlight changed attributes
Status: RESOLVED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2007-02-13 14:34 EST by Willian Mitsuda CLA
Modified: 2007-02-21 20:33 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Willian Mitsuda CLA 2007-02-13 14:34:07 EST
I don't remember if there was a bug opened about this, but search is not cooperating...

When you change you bug attribute, like target milestone, after submit, the combo is not highlighted like new incoming comments and other read-only attributes.
Comment 1 Robert Elves CLA 2007-02-15 13:38:15 EST
If the change was made by you, after submission, the attribute shouldn't be highlighted since the change was made by you. Only changes made by others should appear highlighted in the editor. Are you expecting different behaviour?
Comment 2 Willian Mitsuda CLA 2007-02-15 16:24:43 EST
(In reply to comment #1)
> If the change was made by you, after submission, the attribute shouldn't be
> highlighted since the change was made by you. Only changes made by others
> should appear highlighted in the editor. Are you expecting different behaviour?
> 

There is something strange here. I opened this bug because I marked a bug as RESOLVED FIXED and set the milestone. It was on a 1.0.1 release, I think.

On this case, on editor automatic reopen, the Status and Resolution fields were highlighted, but Target Milestone wasn't.

I just tried on 20070214-1830 M5 dev-build, and happened what you said: nothing was highlighted. Was this a proposital change? I liked the old behavior.
Comment 3 Robert Elves CLA 2007-02-19 12:51:33 EST
Yes, the editor should now only highlight incoming changes (but not those submitted by you). Although currently (M1) upon submission of a new comment it will appear with the highlighted (but this is a 'bug').  
Comment 4 Willian Mitsuda CLA 2007-02-19 13:05:25 EST
Was there some motivation to have the old behavior "fixed"?

I like the old highlighting policy because it gives me the feedback that my changes were persisted.
Comment 5 Eugene Kuleshov CLA 2007-02-19 14:29:08 EST
There is also issue with editor collapsing all sections after submission. I think it should restore expanded sections, scroller position and focus location after submission or task refresh.
Comment 6 Robert Elves CLA 2007-02-19 20:36:41 EST
 (In reply to comment #5)
> There is also issue with editor collapsing all sections after submission. I
> think it should restore expanded sections, scroller position and focus location
> after submission or task refresh.
See bug#172033

 (In reply to comment #4)
> Was there some motivation to have the old behavior "fixed"?
> I like the old highlighting policy because it gives me the feedback that my
> changes were persisted.
This is sounds like a 'trust' issue no?  I.e. you aren't shown the changes you made in the bugzilla web ui for example.  
Comment 7 Eugene Kuleshov CLA 2007-02-19 21:02:17 EST
 (In reply to comment #6)
> > Was there some motivation to have the old behavior "fixed"?
> > I like the old highlighting policy because it gives me the feedback that my
> > changes were persisted.
> This is sounds like a 'trust' issue no?  I.e. you aren't shown the changes you
> made in the bugzilla web ui for example.

I may agree with Willian in case if comment been submitted trough the web UI. I often do that and then see the same issue in Mylar.
Comment 8 Willian Mitsuda CLA 2007-02-20 21:03:57 EST
 (In reply to comment #3)
> Yes, the editor should now only highlight incoming changes (but not those
> submitted by you). Although currently (M1) upon submission of a new comment it
> will appear with the highlighted (but this is a 'bug').

The same happens when you submit a patch.

 (In reply to comment #6)
> This is sounds like a 'trust' issue no?  I.e. you aren't shown the changes you
> made in the bugzilla web ui for example.

Yes, looks like something like this. Perhaps it is just a matter of getting used to this.
Comment 9 Robert Elves CLA 2007-02-21 20:33:13 EST
Well lets see. :) Feel free to reopen discussion if you still feel strongly about this after some more use.