Bug 173752 - [About] Sorting column with Jar signing info in about plugins dialog not working
Summary: [About] Sorting column with Jar signing info in about plugins dialog not working
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-02-10 12:52 EST by Vijay Aravamudhan CLA
Modified: 2008-02-05 10:25 EST (History)
1 user (show)

See Also:


Attachments
Fix (1.64 KB, patch)
2007-05-31 12:16 EDT, Markus Keller CLA
no flags Details | Diff
Screenshot showing the dialog (79.47 KB, image/png)
2008-01-09 18:53 EST, Vijay Aravamudhan CLA
no flags Details
Sort after signed state resolved (4.04 KB, patch)
2008-01-14 10:20 EST, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vijay Aravamudhan CLA 2007-02-10 12:52:37 EST
Build ID: 3.3 M5

Steps To Reproduce:
1.Open Eclipse 3.3M5
2.Navigate to Help > About Eclipse > Plugin details
3.Click on column header for Jar signing info


More information:
The column is clickable - which leads me to think that the table elements can be sorted. But when clicking, they are not sorted. The order does change - which means that the column header is listening to clicks.
Comment 1 Markus Keller CLA 2007-05-31 12:16:31 EDT
Created attachment 69545 [details]
Fix
Comment 2 Kim Horne CLA 2007-05-31 12:48:22 EDT
Ahh Markus, I was trying to entice some of our junior developers with this piece of low hanging fruit.  Thanks for the patch though :)
Comment 3 Markus Keller CLA 2007-05-31 13:27:06 EDT
Ooops, sorry about that! However, here's a not less exciting extension for your juniors: Sort by a secondary column if the entries in the primary column are equal (either by ID or by the most recently chosen column).
Comment 4 Kim Horne CLA 2007-05-31 13:37:58 EDT
Done:  bug 190288
Comment 5 Vijay Aravamudhan CLA 2007-11-08 07:01:40 EST
Still not working - why not just make that header cell unclickable?
Comment 6 Kim Horne CLA 2007-12-17 14:20:32 EST
Fix in HEAD.
Comment 7 Vijay Aravamudhan CLA 2008-01-09 18:50:06 EST
This is still not working. I will attach a screen shot with the latest I build (Version: 3.4.0
Build id: I20080108-1320)
Comment 8 Vijay Aravamudhan CLA 2008-01-09 18:53:44 EST
Created attachment 86519 [details]
Screenshot showing the dialog
Comment 9 Markus Keller CLA 2008-01-14 10:20:31 EST
Created attachment 86829 [details]
Sort after signed state resolved

(In reply to comment #7)
> This is still not working. I will attach a screen shot with the latest I build
> (Version: 3.4.0 Build id: I20080108-1320)

You've probably clicked the column before the signed state of all plug-ins has been resolved. Here's a patch that makes sure the table is re-sorted after all plug-ins' signed states are available.

Live sorting would likely flicker and would require much more work to implement (would have to make sure that verification is only triggered once per plug-in, even if the image is requested multiple times because all items are refreshed).
Comment 10 Kim Horne CLA 2008-01-14 10:35:46 EST
Thanks Markus!  I've applied the patch assuming this is the scenario you were encountering Vijay.  Please reopen after the next integration build if this is still an issue.
Comment 11 Kim Horne CLA 2008-02-05 10:25:17 EST
Verified in I20080205-0010