Bug 173652 - RepositoryProviderManager.removeListener adds the listener instead of removing it
Summary: RepositoryProviderManager.removeListener adds the listener instead of removin...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-02-09 10:22 EST by Missing name CLA
Modified: 2007-06-05 15:31 EDT (History)
0 users

See Also:

Attachments
Patch: apply to org.eclipse.team.internal.core.RepositoryProviderManager (762 bytes, patch)
2007-02-09 10:23 EST, Missing name CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name CLA 2007-02-09 10:22:39 EST 
Build ID: M20060921-0945

Steps To Reproduce:
1. Obtain the shared instance of org.eclipse.team.internal.core.RepositoryProviderManager through RepositoryProviderManager.getInstance()
2. Invoke addListener(myListener)
3. Share a project: myListener.providerMapped() is invoked
4. Invoke removeListener(myListener)
5. Share another project: myListener.providerMapped() is again invoked


More information:
The problem is at lines 56 of org.eclipse.team.internal.core.RepositoryProviderManager which performs add instead of remove

	public void removeListener(IRepositoryProviderListener listener) {
		listeners.add(listener);
	}
Comment 1 Missing name CLA 2007-02-09 10:23:43 EST 
Created attachment 58659 [details]
Patch: apply to org.eclipse.team.internal.core.RepositoryProviderManager
Comment 2 Michael Valenta CLA 2007-02-09 10:46:07 EST 
Isn't that embarrassing. Thanks for providing a patch although, in this case, I already had the fix ready before I got notification that you provided the patch. Next time, I'll wait a bit ;-)