Community
Participate
Working Groups
Team has an action set that provides a main menu and a toolbar item. These should be converted to the new menu support.
Created attachment 59139 [details] Intial version of the patch file Michael please take a look at it
Created attachment 59140 [details] mylar/context/zip
The patch seems to have some problems applying (i.e. files that already exist sow up as additions (e.g. plugin.xml). Could you synchronize with the latest in HEAD, catchup with what is there (i.e. Update) and then recreate the patch? If you end up with conflicts after you Update, you may need to perform a Mark As Merged in order to create the patch properly.
Created attachment 59355 [details] Updated version of the patch Synchronization of our internal CVS with Eclipse's public server isn't a trvial tasks. It's getting even harder when there are branches included. However, using CVS should be an essential skill for every programmer so I hope (I'm sure :)) this time the patch will be applicable.
I've had a look at the patch and here are my initial comments: 1) There were some changes to 3 Actions classes. I think these were just some reformatting and the addition of a deprecated tag. We don't need to add any deprecated tags since these actions are not API. Also, we will hold off on removing any classes until after all the new classes are in. This will make it easier to compare the old behavior with the new. 2) Converting all the old actions to handlers is going to be hard to verify via code inspection (which is what I will need to do). I think it would be good if we could convert our existing classes into handlers in some way. Here are some of the options I see: a) Have TeamAction implement IHandler and duplicate the functionality of AbstractHandler. CVSAction already does this so we could push that up to TeamAction. b) Have TeamAction extend AbstractHandler and duplicate the functionality in ActionDelegate. c) Create a handler wrapper that wraps the existing action delegates I think we need to pick one of these in order to ensure that we can reasonably work with the patches you are going to provide. Could you investigate these three approaches and let me know which one you think we should choose. 3) There seem to be some duplicate commands defined in the plugin.xml (e.g Apply Patch, Synchronize). Each command should only be defined once. 4) There don't seem to be any handlers defined in the plugin.xml. 5) I noticed the team.main group is defined but the compareWith and replaceWith groups are not. These groups are defined in the org.eclipse.compare plug-in so we'll need to convert that plug-in to the new menu support as well (i.e. it is part of Team). So, I think the next thing we can do is address point 2. Once we have settled on a solution for that, perhaps we could start by getting Apply Patch and Share Project working in the main menu (since there are still some issues holding up objectContribution conversion). From the patch, it looks like you may have these two working already but the shape of the code will change due to point 2. How does that sound?
Created attachment 59496 [details] Next version of the patch (proposition) The patch is mostly addressed to issue 2a from Michael's comment for this bug
This is not containable in the 3.3 release so we're postponing it until 3.4.
I hope I will have time to get back to this issue during 3.5 cycle, until then let's update the target milestone to better match the reality.
We don't plan to address it now. I'm removing the target milestone but we'll set more realistic one when we have feedback from anyone interested in fixing this.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
