Bug 173052 - [Contributions] CommandContributionItem does not show keybinding
Summary: [Contributions] CommandContributionItem does not show keybinding
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: ali sheraz CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-02-06 09:11 EST by Paul Webster CLA
Modified: 2007-06-05 16:35 EDT (History)
0 users

See Also:

Attachments
about project v01 (2.16 KB, application/zip)
2007-03-02 15:14 EST, Paul Webster CLA 		no flags Details
Code added in CommandContributionItem to fix this bug (2.26 KB, patch)
2007-03-08 18:23 EST, ali sheraz CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2007-02-06 09:11:15 EST 
Placing a command contribution item or <command/> element in a menu and it won't show the keybinding.

PW
Comment 1 Paul Webster CLA 2007-03-02 14:37:51 EST 
Ali,

Check out IBindingService getBestActiveBindingFor, and check out how ActionContributionItem formats that and appends it to the setText(*) call.

PW
Comment 2 Paul Webster CLA 2007-03-02 15:14:32 EST 
Created attachment 60204 [details]
about project v01

This contributes AboutKey to the Help menu and a keybinding for the about command.

PW
Comment 3 ali sheraz CLA 2007-03-08 18:23:54 EST 
Created attachment 60456 [details]
Code added in CommandContributionItem to fix this bug

Bug Fix is attached, Please review it and commit it.
Ali
Comment 4 Paul Webster CLA 2007-03-08 19:22:06 EST 
Released >20070308 with slight mods ... you don't have to save commandId, and you should delete the code you just commented out.

PW
Comment 5 Paul Webster CLA 2007-03-23 08:32:17 EDT 
in I20070322-1800
PW
Comment 6 Kim Horne CLA 2007-03-23 08:34:15 EDT 
Verified in I20070322-1800