Bug 172915 - [Webapp] Accessiblity:Some content is cut off in Help document if high contrast+Large font.
Summary: [Webapp] Accessiblity:Some content is cut off in Help document if high contra...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P1 major (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2007-02-05 15:52 EST by Michael Burkhart CLA
Modified: 2007-03-28 19:22 EDT (History)
3 users (show)

See Also:

Attachments
Select Search Scope on 3.2.2 (124.25 KB, image/pjpeg)
2007-02-05 15:53 EST, Michael Burkhart CLA 		no flags Details
Select Search Scope->New Search List on 3.2.2 (140.30 KB, image/pjpeg)
2007-02-05 15:53 EST, Michael Burkhart CLA 		no flags Details
Select Search Scope on 3.3 (136.71 KB, image/pjpeg)
2007-02-05 15:54 EST, Michael Burkhart CLA 		no flags Details
Patch for 3.3 (2.23 KB, patch)
2007-03-22 14:10 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
Patch for Eclipse 3.2.2 (20.49 KB, patch)
2007-03-28 19:22 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Burkhart CLA 2007-02-05 15:52:38 EST 
[Steps]
1.Enable High Contrast Black (Extra Large) from control panel.
2.Choose Help menu and click "help topic..." item.
3.As the following picture,click "Search Scope" and click the "new"button in the Select Search window.

In the above picture,some buttons and items and window title in red rectangle are cut off screen.

I have tested this on 3.3 and the issues with the New Search List dialog window appear to have been resolved, but the issues with the Select Search Scope dialog still seem to exist. Please see the attachments.
Comment 1 Michael Burkhart CLA 2007-02-05 15:53:08 EST 
Created attachment 58280 [details]
Select Search Scope on 3.2.2
Comment 2 Michael Burkhart CLA 2007-02-05 15:53:40 EST 
Created attachment 58281 [details]
Select Search Scope->New Search List on 3.2.2
Comment 3 Michael Burkhart CLA 2007-02-05 15:54:00 EST 
Created attachment 58282 [details]
Select Search Scope on 3.3
Comment 4 Michael Burkhart CLA 2007-03-12 15:02:25 EDT 
update severity to major based on product criticality.
Comment 5 Chris Goldthorpe CLA 2007-03-12 15:46:45 EDT 
I'll work on getting this fixed for 3.3.
Comment 6 Philipe Mulet CLA 2007-03-21 16:34:10 EDT 
Please make sure to attach the 3.3 patch, and risk assesment for a 3.2.2 backport.
Comment 7 Chris Goldthorpe CLA 2007-03-22 13:37:29 EDT 
I have a fix for this and it will be committed early next week. When you said that you wanted a patch attached is this for use in 3.2.2? If so I would need to go prepare a patch for Eclipse 3.2.2 since the code in searchScoped.jsp has changed a little between 3.2 and 3.3. I don't believe that this would be a high risk fix once we have tested on the major platforms and browsers.
Comment 8 Philipe Mulet CLA 2007-03-22 13:47:22 EDT 
Thanks. You only need to attach a patch against 3.3 code base (i.e. the change you are currently doing), and indicate your feel about backporting it to 3.2.2.
Comment 9 Chris Goldthorpe CLA 2007-03-22 14:10:25 EDT 
Created attachment 61719 [details]
Patch for 3.3

This is the patch for Eclipse 3.3. I can't say for sure whether it will work on Eclipse 3.2.2 without testing it there, some code was added in 3.3 to make the contents adapt to the size of the dialog if the user resizes the dialog when using an external browser.
Comment 10 Chris Goldthorpe CLA 2007-03-26 11:40:44 EDT 
Fixed in HEAD.
Comment 11 Chris Goldthorpe CLA 2007-03-28 19:20:02 EDT 
The patch I attached does NOT fix the underlying problem on Eclipse 3.2.2 because it relies on the code I added in Eclipse 3.3 to allow the Working Set dialogs to resize. I will attach a new patch for 3.2.2
Comment 12 Chris Goldthorpe CLA 2007-03-28 19:22:34 EDT 
Created attachment 62312 [details]
Patch for Eclipse 3.2.2