Bug 172734 - [PropertiesDialog] PropertyDialogAction.isApplicableForSelection does not consider if the page is applicable
Summary: [PropertiesDialog] PropertyDialogAction.isApplicableForSelection does not con...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 189162 (view as bug list)
Depends on:
Blocks: 189162
  Show dependency tree
 
Reported: 2007-02-02 17:56 EST by Darin Swanson CLA
Modified: 2008-02-05 13:06 EST (History)
3 users (show)

See Also:

Attachments
proposed patch (876 bytes, patch)
2007-08-22 17:17 EDT, Darin Swanson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2007-02-02 17:56:28 EST 
PropertyDialogAction.isApplicableForSelection returns true no matter if none of the IPropertyPageContributor are applicable to the object (return true for isApplicableTo(Object).

I would propose the implementation of PropertyDialogAction.isApplicableForSelection should use PropertyPageContributorManager.getApplicableContributors
Comment 1 Darin Swanson CLA 2007-08-22 17:17:54 EDT 
Created attachment 76717 [details]
proposed patch
Comment 2 Tod Creasey CLA 2007-10-11 14:12:57 EDT 
I have also updated the javadoc of isApplicableForSelection . Patch released for build >20071011
Comment 3 Darin Swanson CLA 2007-10-11 14:30:31 EDT 
Thanks Tod.
Comment 4 Tod Creasey CLA 2007-10-29 14:07:50 EDT 
Verified in I20071029-0100
Comment 5 Martin Oberhuber CLA 2008-02-05 13:06:45 EST 
*** Bug 189162 has been marked as a duplicate of this bug. ***