Bug 172699 - [new uex] create new task list query from search results
Summary: [new uex] create new task list query from search results
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Balazs Brinkus CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks: 359147
  Show dependency tree
 
Reported: 2007-02-02 14:10 EST by Robert Elves CLA
Modified: 2011-09-27 17:41 EDT (History)
1 user (show)

See Also:


Attachments
create query from task search (5.82 KB, patch)
2007-06-04 18:11 EDT, Balazs Brinkus CLA
no flags Details | Diff
mylar/context/zip (60.10 KB, application/octet-stream)
2007-06-04 18:11 EDT, Balazs Brinkus CLA
no flags Details
create query from task search image (952 bytes, application/octet-stream)
2007-06-04 18:12 EDT, Balazs Brinkus CLA
no flags Details
AddTaskListAction (8.27 KB, patch)
2007-06-22 19:37 EDT, Balazs Brinkus CLA
no flags Details | Diff
mylar/context/zip (97.59 KB, application/octet-stream)
2007-06-22 19:37 EDT, Balazs Brinkus CLA
no flags Details
AddTaskListAction v.2 (6.02 KB, patch)
2007-06-24 17:38 EDT, Balazs Brinkus CLA
no flags Details | Diff
mylyn/context/zip (99.42 KB, application/octet-stream)
2007-06-24 17:38 EDT, Balazs Brinkus CLA
no flags Details
mylyn/context/zip (110.21 KB, application/octet-stream)
2007-06-24 22:58 EDT, Mik Kersten CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Elves CLA 2007-02-02 14:10:27 EST
Should be able to automatically create a query in the task list based on the last executed Task Search. Perhaps we could contribute a button to the search results view.   First iteration might just be to add a button to the Task Search page that will create a query based on the currently selected parameters (last executed query).
Comment 1 Eugene Kuleshov CLA 2007-02-02 14:41:29 EST
Hmm. Why not from the popup menu in a search view?

Also, it would be really convenient to be able to edit the search criteria when refreshing the search results. I often find that I need to adjust criteria, and now these adjustments are polluting history of the Search view.
Comment 2 Mik Kersten CLA 2007-02-05 19:11:20 EST
Nice ideas, because they streamline the workflow.  So we could have two popup menu actions (titles overly long):
1) Edit Search Parameters
2) Create Task List Query from Search Parameters
Comment 3 Mik Kersten CLA 2007-04-23 08:08:00 EDT
Tagging as "new user experience".  

Rob, Eugene: if you encounter other bugs in this category please tag them as such since we have a summer of code student dedicated to this.
Comment 4 Balazs Brinkus CLA 2007-06-04 18:11:17 EDT
Created attachment 70042 [details]
create query from task search

I finish the query part of the bug.
Comment 5 Balazs Brinkus CLA 2007-06-04 18:11:23 EDT
Created attachment 70043 [details]
mylar/context/zip
Comment 6 Balazs Brinkus CLA 2007-06-04 18:12:04 EDT
Created attachment 70045 [details]
create query from task search image
Comment 7 Mik Kersten CLA 2007-06-06 22:29:13 EDT
Balazs: this contribution belongs in ..mylar.tasks.ui.

Please note bug 191406, since this could cause a hiccup in applying patches tomorrow.  If the patch comes in early I will try to apply it right away.   The merge won't be too painful if not.
Comment 8 Balazs Brinkus CLA 2007-06-09 21:12:27 EDT
The TaskSearchPage's IDs are different. 
In the plugin.xml the ID is "org.eclipse.mylyn.tasks.ui.search.page". 
In the file the ID is "org.eclipse.mylyn.tasks.ui.core.search.page".
Can I overwrite the file's ID?
Comment 9 Balazs Brinkus CLA 2007-06-10 09:44:11 EDT
I found a problem which I can't resolve. The problem is the search results removing.
These results are stored in the QueryManager object which is non-public. So I can't use it.
The InternalSearchUi.removeQuery() method not only remove it, but it stop the running query too.
So I have some ideas, which is the best.
1. Remove the last search result from the history before I start the new search. This has one disadvantage, if the user cancel the new search I can't restore the last search result.
2. After the new search start I observe the search running (with a while loop inside a Thread.sleep()). After it will be finished I will remove the last search.
3. Write a request that modify the QueryManager to public. I think this will be the best, but I don't know, that will be solvable.
What do you think about these ideas?
Comment 10 Mik Kersten CLA 2007-06-15 15:10:21 EDT
Rob: when you have a chance please review.
Comment 11 Mik Kersten CLA 2007-06-21 15:09:57 EDT
Balazs: in the meantime could you explore adding an "Add to Task List" action to the search results view?
Comment 12 Balazs Brinkus CLA 2007-06-22 19:37:19 EDT
Created attachment 72237 [details]
AddTaskListAction

I finished the "Add to Task List" action.
I found a bug. The TaskUiPlugin ids were different. So I modified the class file's id.
I included this modification in this patch, but if it's needed I will report this bug.
Comment 13 Balazs Brinkus CLA 2007-06-22 19:37:29 EDT
Created attachment 72238 [details]
mylar/context/zip
Comment 14 Mik Kersten CLA 2007-06-24 16:32:31 EDT
Balazs: I'm getting conflicts in the patch.  Could you please synchronize and try to create it again?
Comment 15 Balazs Brinkus CLA 2007-06-24 17:38:28 EDT
Created attachment 72304 [details]
AddTaskListAction v.2

New version of "Add to Task List" action.
Comment 16 Balazs Brinkus CLA 2007-06-24 17:38:32 EDT
Created attachment 72305 [details]
mylyn/context/zip
Comment 17 Mik Kersten CLA 2007-06-24 22:58:33 EDT
Great work Balazs!  This will make it into the New & Noteworthy.

Please synch up and note the changes that I made to AddTaskListAction, now called CreateQueryFromSearchAction.  The structure that you set up was perfect, I just changed the way that the image is retrieved and the wording in the UI.  

I also added a way to add individual hits to the Task List, so check that out.  It will help keep the UI simple for bug 193423.
Comment 18 Mik Kersten CLA 2007-06-24 22:58:38 EDT
Created attachment 72317 [details]
mylyn/context/zip