Community
Participate
Working Groups
SSIA. Patch to follow.
Created attachment 58074 [details] patch against v3324 In make_linux.mak, I couldn't find references to 'c.o' or 'c_stats.o' so I removed them. In build.sh I changed GECKO_{INCLUDES,LIBS} to MOZILLA_{INCLUDES,LIBS} so this file would work with the changes in make_linux.mak and I added a check for firefox-xpcom if mozilla-xpcom can't be found. It would be great to see this fix in 3.3M5. Thanks, Ben
fixed > 0202, excluding the removal of c.o and c_stats.o. Thanks for the patch!
No problem. What's the deal with c.o and c_stats.o? Will I be able to compile SWT in the 3.3M5 source drop?
Do the c.o and c_stats.o prevent you from compiling successfully? These are needed because some of the platform-common functions from os have moved into c. Is the source build failing to find c.o and c_stats.o when it is compiling the swt libraries?
(In reply to comment #4) > Do the c.o and c_stats.o prevent you from compiling successfully? These are > needed because some of the platform-common functions from os have moved into c. > Is the source build failing to find c.o and c_stats.o when it is compiling the > swt libraries? Yes, that is correct, c.c and c_stats.c are not found when compiling the swt libraries with the source drop. If you look at the 'compilelibs' target main build file: http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk/srcBuild/build.xml?view=markup you will see that the swt libs are compiled from the src.zip in plugins/org.eclipse.rcp.source.${installOs}.${installWs}.${installArch}/src/org.eclipse.swt.${installWs}.${installOs}.${installArch}_*/. I think that whatever generates this src.zip is not including the files from Eclipse SWT PI/common/library/ and should. I'm re-opening this bug until this problem is resolved. Thanks.
Will this be fixed in 3.3M5?
Yes, this is fixed in HEAD (again) and will be included in today's 6:00pm build. The c files now appear in the root of swt's source zip.
Thanks Grant!
