Bug 172455 - [Actions] Tag as Version... on file with uncommitted changes give inaccurate warning
Summary: [Actions] Tag as Version... on file with uncommitted changes give inaccurate ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-02-01 05:56 EST by Dani Megert CLA
Modified: 2007-08-08 06:23 EDT (History)
2 users (show)

See Also:

Attachments
The dialog (8.00 KB, image/png)
2007-02-01 05:57 EST, Dani Megert CLA 		no flags Details
Fix (1.37 KB, patch)
2007-06-21 06:28 EDT, Dani Megert CLA 		no flags Details | Diff
Fix - no details message (3.08 KB, text/plain, text/file)
2007-06-21 06:31 EDT, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-02-01 05:56:45 EST 
I20070130-0800.

1. select a shared file
2. do some changes in that file and save it
3. select the file and then Team > Tag as Version...
4. enter a tag and press 'OK'
==> a dialog warns about this and says that the file will not be tagged. However, the underlying revision will be tagged. This is clearly reflected in the dialog.
Comment 1 Dani Megert CLA 2007-02-01 05:57:09 EST 
Created attachment 57991 [details]
The dialog
Comment 2 Dani Megert CLA 2007-06-21 06:28:50 EDT 
Created attachment 72021 [details]
Fix
Comment 3 Dani Megert CLA 2007-06-21 06:31:27 EDT 
Created attachment 72022 [details]
Fix - no details message

This second patch removes the detail header message which in my opinion is redundant, but I'm fine with fix 1 as well.
Comment 4 Michael Valenta CLA 2007-06-21 06:34:29 EDT 
Thanks Dani
Comment 5 Michael Valenta CLA 2007-06-21 09:48:47 EDT 
Patch released to HEAD. Thanks again.
Comment 6 Krzysztof Michalski CLA 2007-08-07 07:05:53 EDT 
Fix verified.