Bug 172216 - [EditorMgmt] Editors not added to history
Summary: [EditorMgmt] Editors not added to history
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-30 14:38 EST by Michael Valenta CLA
Modified: 2019-09-06 16:14 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2007-01-30 14:38:15 EST
Using the new editor reuse feature, there are situations where an editor that is opened in an existing editor doesn't get added to the history. I can see this by doing the following:

1) Open an editor of a Java file
2) F3 on another class
3) click back in the editor history nav and the first editor is opened.
4) However, I cannot click forward to the second class.
Comment 1 Michael Valenta CLA 2007-01-30 14:45:43 EST
Here's another failure case. If I choose a content assist to create a method on an interface, the interface is opened in an editor but the edit history gets totally hosed (i.e. becomes empty). I would expect that clicking back would take me back to where I was working.
Comment 2 Michael Valenta CLA 2007-01-30 14:47:21 EST
It would also be nice if dirty editors were kept on the tab line of possible. I find they more to the drop down too soon (i.e. I have one dirty editor and it is not on the tab line).
Comment 3 Boris Bokowski CLA 2007-01-30 14:50:47 EST
(In reply to comment #1)
> Here's another failure case. If I choose a content assist to create a method on
> an interface, the interface is opened in an editor but the edit history gets
> totally hosed (i.e. becomes empty). I would expect that clicking back would
> take me back to where I was working.

This is by design - the new editor is in a new tab, and each tab has its own history.  You could try "Last Edit Location", it's the arrow with a star in the toolbar.

Would it help if new tabs were not opened at the very end, but to the immediate right of the current tab?  If we implemented this, you could go to the tab to the left (key: Ctrl-PageUp) to get back to where you were.
Comment 4 Boris Bokowski CLA 2007-01-30 15:17:59 EST
(In reply to comment #2)
> It would also be nice if dirty editors were kept on the tab line of possible. I
> find they more to the drop down too soon (i.e. I have one dirty editor and it
> is not on the tab line).

There is something weird with the set of currently displayed tabs, I will have to investigate what's going on.  However, I don't want to reorder tabs automatically.  We might need a smaller minimum size for the tabs before we show the chevron.
Comment 5 Michael Valenta CLA 2007-01-30 15:32:45 EST
Regarding history navigation, I think one of the things that is messing up your metaphor is editor pinning. If I pin an editor (or have modified it), "navigating" to another file will open another editor. However, I don't view this as a separate "stack" (i.e. I would expect the back button to take me back to the editor I just left). I'll try to re-train myself to use the Last Edit Location and see if that helps.

Regarding the dirty editors leaving the tab, if the behavior is the same as it was then thats OK. I just don't remember my dirty editors leaving the tab as often as they do now. However, I think it would be useful to have some way for the user to indicate that they want their dirty editors to be kept on the tab as long as possible (or perhaps a key binding to cycle through dirty editors).
Comment 6 Boris Bokowski CLA 2009-11-17 13:04:42 EST
Remy is now responsible for watching the [EditorMgmt] component area.
Comment 7 Eclipse Webmaster CLA 2019-09-06 16:14:57 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.