Bug 172198 - [Viewers] Don't hide highlighted changes with selection when stepping
Summary: [Viewers] Don't hide highlighted changes with selection when stepping
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2007-01-30 12:57 EST by Dani Megert CLA
Modified: 2007-05-01 10:52 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-01-30 12:57:19 EST 
I20070130-0800

It's great that I can now highlight individual diffs in the compare editor but this is only useful if you don't step through diffs because when
stepping, the selection hides the useful information. Could we allow to not set
the selection when stepping through changes in that mode? Another approach would be to replace the selection with a custom background highlighting that is brighter than the color for the individual diffs.
Comment 1 Markus Keller CLA 2007-01-30 14:02:25 EST 
> [..] when stepping through changes in that mode [..]
I would always do it the same.

I'd vote for setting the caret to the beginning of the difference's range when using Next Difference (but still select for Next Change).
Comment 2 Michael Valenta CLA 2007-04-09 16:17:52 EDT 
Fix released to HEAD with the following behavior:

1) The highlighting behavior for Next Change should not have changed.

2) When token highlighting is off, there is no change in behavior.

3) When highlighting is on, diffs are not highlighted unless they have no children.
Comment 3 Michael Valenta CLA 2007-04-09 16:18:29 EDT 
By "no children" I mean, no token level changes.
Comment 4 Michael Valenta CLA 2007-05-01 10:52:57 EDT 
Verified in I20070501-0010