Bug 17208 - Long operations are being modal.
Summary: Long operations are being modal.
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 normal (vote)
Target Milestone: 2.0 F4   Edit
Assignee: Steve Northover CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-23 08:41 EDT by Eduardo Pereira CLA
Modified: 2002-06-19 11:32 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Pereira CLA 2002-05-23 08:41:23 EDT
Build: F1

Open the import dialog.
Import something the will take several minutes.
Comment 1 Eduardo Pereira CLA 2002-05-23 08:55:50 EDT
[Did not finish logging it. Bugzilla!].

1) Make sure you have more than one window with a Java Perspective active.
2) Open the import dialog.
3) Import something the will take several minutes.
     * Import all external plugins for example.
4) Don't wait it to finish.
5) Using "ALT+TAB", got to another window.
6) Press CTRL+SHIFT+T, type a name of a class and enter.

Eclipse is not thread safe and we may end up getting all sort of errors.
The import dialog is modal. It should not let the user do something else in 
another window.

Comment 2 Eduardo Pereira CLA 2002-05-23 08:57:59 EDT
Should have opened in SWT. The dialog acts like modal if you try to access 
another window using the mouse; the problem happens only when using 
accelerators.
Comment 3 Mike Wilson CLA 2002-05-23 10:35:58 EDT
Accelerators can not be active while a modal dialog is running. Must fix.
Comment 4 Steve Northover CLA 2002-05-27 21:12:01 EDT
Fixed > 20020527.
Comment 5 John Arthorne CLA 2002-05-31 10:35:00 EDT
I'm still experiencing this in build 20020530 on Win2k.  Should the fix be in 
this build?  I was very easily able to deadlock eclipse by starting builds from 
two windows at once.
Comment 6 John Arthorne CLA 2002-05-31 10:38:20 EDT
I'm sorry... this appears to be a different case.  I just noticed that the 
incremental build doesn't use a modal dialog anymore, it just uses a busy 
cursor.  This may not be an SWT problem, I will file a new bug.
Comment 7 Nick Edgar CLA 2002-05-31 19:57:20 EDT
The deadlock you saw is probably due to bug 2229 and is not an SWT problem.
Comment 8 Nick Edgar CLA 2002-05-31 19:57:43 EDT
John, please see previous comment.
Comment 9 Eduardo Pereira CLA 2002-06-18 17:05:03 EDT
Still a problem in build 0618.
I think this should be considered for F4.

Steps: 
 1) Open two workbench windows.
 2) Open a modal dialog in one (File->Import)
 3) Use Alt+Tab to go to the other window.
 4) Use Alt+Char to get to a menu 
     (Alt+N T for example to open type in the Java Perspective)
Comment 10 Mike Wilson CLA 2002-06-19 09:21:09 EDT
Steve, please investigate. Let me know as soon as you know what's going on.
Comment 11 Steve Northover CLA 2002-06-19 10:13:07 EDT
I have a fix in hand.  It is low risk.  It involves testing for "disabled && 
modal" in one place instead of testing only for "disabled".  We should put it 
in.
Comment 12 Steve Northover CLA 2002-06-19 11:32:36 EDT
Fixed > 20020619