Bug 172077 - [PropertiesDialog] PropertyDialog shows bad messages for non-IWorkbenchAdapter objects
Summary: [PropertiesDialog] PropertyDialog shows bad messages for non-IWorkbenchAdapte...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug hasPatch
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-01-29 17:17 EST by Jared Burns CLA
Modified: 2021-12-29 01:10 EST (History)
3 users (show)

See Also:


Attachments
Patch to make changes from description (4.87 KB, patch)
2008-09-16 20:00 EDT, Trevor CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2007-01-29 17:17:08 EST
PropertyDialog#createDialogOn(...) presents bad messages if it is called with an object which does not adapt to IWorkbenchAdapter.

If no property pages are found for the object, a message dialog is opened which reads:
   "No property pages found for ."

If property pages *are* found for the object, the property dialog is opened with the title:
   "Properties for"

If a valid name cannot be determined for the object, these messages should read:
   "No property pages found."
   "Properties"
Comment 1 Markus Keller CLA 2008-01-07 10:42:05 EST
The "Properties for" case can e.g. be observed when File > Properties is called when an editor is active.
Comment 2 Trevor CLA 2008-09-16 20:00:26 EDT
Created attachment 112716 [details]
Patch to make changes from description

This patch adds two messages:
 PropertyDialog_noNameNoPropertyMessage
 PropertyDialog_noNamePropertyMessage

and changes the public static method getName(Object) to return null when the object does not adapt to a IWorkbenchAdapter.

I was able to test the case in the comments manually, ie File > Properties with a Editor active. But I was not able to create a situation where I could ask for properties of an object which had no property pages and was not a IWorkbenchAdapter.

Feedback appreciated
  Trevor Kaufman
Comment 3 Trevor CLA 2009-06-16 16:11:03 EDT
Hey, this is getting old..

 Whats up here?
Comment 4 Markus Keller CLA 2009-06-18 05:27:29 EDT
Reassigning to inbox.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:03:37 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 6 Eclipse Genie CLA 2021-12-29 01:10:40 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.