Bug 171983 - [Preferences] Wrong ref to preference page on 'Server Encoding' property page
Summary: [Preferences] Wrong ref to preference page on 'Server Encoding' property page
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Krzysztof Michalski CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-01-29 04:04 EST by Dani Megert CLA
Modified: 2007-06-05 15:18 EDT (History)
0 users

See Also:

Attachments
Image of the property page (9.88 KB, image/png)
2007-01-29 04:05 EST, Dani Megert CLA 		no flags Details
Proposition of changes (4.77 KB, patch)
2007-04-20 14:04 EDT, Krzysztof Michalski CLA 		no flags Details | Diff
Changes adressing Michael comments (4.55 KB, patch)
2007-04-23 06:16 EDT, Krzysztof Michalski CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-01-29 04:04:18 EST 
3.3 M4

Open the properties of a CVS repository and switch to the 'Server Encoding' preference page. On this page is a hint (see picture) where to set the workspace encoding. This linke is wrong. It should be "General > Workspace" and even better it should be a real link.
Comment 1 Dani Megert CLA 2007-01-29 04:05:08 EST 
Created attachment 57684 [details]
Image of the property page
Comment 2 Michael Valenta CLA 2007-03-01 10:40:02 EST 
In the very least, we need to fix the test but should investigate whether linking to the General/Workspace preference page is possible.
Comment 3 Krzysztof Michalski CLA 2007-04-20 14:04:04 EDT 
Created attachment 64480 [details]
Proposition of changes

I created a link to General/Workspace as you suggesteg.
Comment 4 Michael Valenta CLA 2007-04-20 15:32:44 EDT 
The patch is good but why do you close the properties dialog before opening the preferences dialog. I think the user would expect the repository properties dialog to remain open while they edit the general preferences.

One thing you have to watch out for is shell parenting. To make the above work, you would need to pass the shell of the Properties dialog to the createPreferenceDialogOn method so that the new dialog was parented off the old one.
Comment 5 Krzysztof Michalski CLA 2007-04-23 06:16:45 EDT 
Created attachment 64588 [details]
Changes adressing Michael comments
Comment 6 Michael Valenta CLA 2007-04-23 11:01:20 EDT 
Patch released