Community
Participate
Working Groups
I20070123-1715 The Javadoc of FilteredItemsSelectionDialog.ItemsFilter#equalsFilter(ItemsFilter) does not tell how this method is used. It should - tell whether the method is symmetric like Object#equals(..) - or even better: tell that subclasses of FilteredItemsSelectionDialog can be sure that the arguments to equalsFilter(ItemsFilter) are only filters returned from their createFilter() method (=> clients can avoid instanceof checks then) Furthermore, current implementations of that method are questionable: - FilteredItemsSelectionDialog.ItemsFilter.equalsFilter(ItemsFilter) checks for "iFilter != null", although the constract does not allow iFilter to be null - FilteredResourcesSelectionDialog.ResourceFilter.equalsFilter(ItemsFilter) and FilteredTypesSelectionDialog.TypeItemsFilter.equalsFilter(ItemsFilter) call "super.equals(iFilter)". Should be "super.equalsFilter(iFilter)"
Created attachment 58121 [details] Patch file including javadoc fixes. This patch is the result of general code review of FilteredItemsSelectionDialog. I focused mainly on Javadoc comments, about which Markus was concerned so much. However, the patch includes also some minor code fixes in FilteredItemsSelectionDialog as well as in subclasses (FResourcesSD and FTypesSD). I am aware that this patch doesn't make Javadoc contracts in all theses classes flawless. However, releasing this patch and logging some comments as new bugs would be appreciated. Especially, due to the fact that this patch introduce changes among almost whole class. Maintaining the patch file (keeping it up-to-date) is going to be "Sisyphus work".
Created attachment 59166 [details] Updated version of the patch
Patch for ide and workbench commited for build >20070219 but as I am not a JDT commiter you will need a seperate patch for them.
I had to back out of this patch as it was pretty big and I needed to get the patch for Bug 172005 in before the build today (sorry). Could you update the patch for ide and workbench please?
I will update the patch as soon as the patch for Bug 172005 is released. I will split it into two seperate patches: one for JDT, one for you.
Created attachment 59384 [details] Updated version of the patch for FISD class This is the patch file only for FISD class. Part for FRSD has been already applied. Part for FTSD (JDT) is comming soon....
Created attachment 59385 [details] Part of the updated patch for JDT
Patch released for build >20070220
(In reply to comment #7) Thanks, applied JDT/UI patch to HEAD. Filed bug 175524 for further API problems.
