Bug 171719 - IMemento/XMLMemento being extended to add functionality
Summary: IMemento/XMLMemento being extended to add functionality
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-01-25 14:19 EST by Tom Mutdosch CLA
Modified: 2007-09-18 14:32 EDT (History)
3 users (show)

See Also:

Attachments
XMLMemento version (4.25 KB, application/octet-stream)
2007-02-26 15:24 EST, Tom Mutdosch CLA 		no flags Details
Patch to add in the four new methods. (6.51 KB, text/plain)
2007-08-31 09:41 EDT, Remy Suen CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Mutdosch CLA 2007-01-25 14:19:51 EST 
Build ID: I20060922-0010

Steps To Reproduce:
This is just a notice that we We are reusing the org.eclipse.ui.XMLMemento with a few changes to suit our needs.  For example we have a getNames() API that returns a List of all of the element's attribute names.   We also added a putBoolean() and getBoolean() method for utility purposes (similar to get/setFloat, etc).  We had to extend the IMemento interface to support this as well.

More information:
Comment 1 Paul Webster CLA 2007-01-25 14:45:18 EST 
As I understand it, you need to post the 2 new files or the patch as well.

PW
Comment 2 Tom Mutdosch CLA 2007-02-26 15:24:28 EST 
Created attachment 59820 [details]
XMLMemento version
Comment 3 Paul Webster CLA 2007-02-27 08:01:54 EST 
Consider contributing some of the changes back to eclipse.

Contribute:
getBoolean()/setBoolean()

Also:
Change getName() to getType()
Change getNames() to getAttributeNames()

PW
Comment 4 Paul Webster CLA 2007-02-27 08:04:46 EST 
(In reply to comment #3)
> Consider contributing some of the changes back to eclipse.

Sorry, that should read Platform UI to consider adopting ...
PW
Comment 5 Eric Moffatt CLA 2007-03-05 11:18:17 EST 
Paul, punt this back if you think there's a better owner for it...(McQ?).
Comment 6 Remy Suen CLA 2007-08-31 09:41:57 EDT 
Created attachment 77464 [details]
Patch to add in the four new methods.

Adding:
-getName() returning String
-getAttributeKeys() returning String[]
-getBoolean() returning Boolean
-setBoolean(String, boolean)

This patch also updates ConfigurationElementMemento which appears to not have been included in the zip file.
Comment 7 Paul Webster CLA 2007-08-31 10:22:02 EDT 
I've released:
-getType() returning String
-getAttributeKeys() returning String[]
-getBoolean() returning Boolean
-setBoolean(String, boolean)

to HEAD >20070831  - thanx for the update, Remy.

PW
Comment 8 Paul Webster CLA 2007-09-18 14:32:27 EDT 
In I20070918-0010
PW