Bug 170718 - Jira silently drops comment
Summary: Jira silently drops comment
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.0 M2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 170333 (view as bug list)
Depends on: 165389
Blocks:
  Show dependency tree
 
Reported: 2007-01-16 19:56 EST by Steffen Pingel CLA
Modified: 2007-02-18 00:10 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2007-01-16 19:56:01 EST
When I try to comment http://mylar.eclipse.org/jiratest/browse/JIRATEST-1 using the Jira editor comments are not attached to the issue.
Comment 1 Mik Kersten CLA 2007-01-21 23:04:46 EST
Any ideas as to why?  We've been testing comments against the following bug:

JDB-100: test Mylar editor integration
http://developer.atlassian.com/jira/browse/JDB-100
Comment 2 Steffen Pingel CLA 2007-01-21 23:30:24 EST
I have only briefly looked at the code but it seems like the changes are submitted through an HTTP post instead of using the SOAP API (see JiraWebIssueServer.updateIssue()). That does not explain why the comment is lost but it seems so much more error prone than using the type-safe API. Are there any good reasons to do it the way it is? Are there any plans to change this once the Jira core services are moved to Mylar (I'll volunteer to remove any println() and e.printStackTrace() statements...) ?
Comment 3 Steffen Pingel CLA 2007-01-22 01:19:00 EST
Further investigation of network dumps showed that the server returns "You do not have permission to edit issues in this project." This makes perfect sense because the user has only permission to comment and not to modify any issue properties which would is required for the form used by  JiraWebIssueServer.updateIssue(). 

The actual problem is that JiraWebIssueServer.updateIssue() ignores the returned output and does not display any error. This seems impossible to fix without modifying Jira core services.
Comment 4 Mik Kersten CLA 2007-02-12 14:49:38 EST
Steffen: that update to JIRA core services can now be made.  Let me know if you want this assigned to you.
Comment 5 Steffen Pingel CLA 2007-02-12 15:04:28 EST
I'll take a look at it this week (if time permits). I still think that it would be best to rewrite the code to use the SOAP API instead of HTTP posts though (see comment 2).
Comment 6 Mik Kersten CLA 2007-02-12 15:26:46 EST
I have no problem at all with that, as long as someone is willing to sign up for doing it :)
Comment 7 Steffen Pingel CLA 2007-02-17 22:53:46 EST
The required reporter property was not set in the POST.

Committed fix to CVS.
Comment 8 Steffen Pingel CLA 2007-02-18 00:10:58 EST
*** Bug 170333 has been marked as a duplicate of this bug. ***