Bug 170630 - [relengtool] Releng.tools should allow changing the default mapfile project
Summary: [relengtool] Releng.tools should allow changing the default mapfile project
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Allan Godding CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2007-01-16 09:56 EST by Martin Oberhuber CLA
Modified: 2007-11-14 12:47 EST (History)
4 users (show)

See Also:


Attachments
Patch for relengtools (32.69 KB, patch)
2007-10-01 09:45 EDT, Allan Godding CLA
no flags Details | Diff
Patch for relengtools (35.08 KB, patch)
2007-10-01 13:34 EDT, Allan Godding CLA
no flags Details | Diff
Patch for relengtools (35.31 KB, patch)
2007-10-01 14:55 EDT, Allan Godding CLA
no flags Details | Diff
patch for releng.tools (35.15 KB, patch)
2007-10-01 15:35 EDT, DJ Houghton CLA
no flags Details | Diff
Patch for relengtools (41.85 KB, patch)
2007-10-03 11:04 EDT, Allan Godding CLA
no flags Details | Diff
Patch for relengtools (44.60 KB, patch)
2007-10-05 10:55 EDT, Allan Godding CLA
no flags Details | Diff
Patch for relengtools (44.68 KB, patch)
2007-10-09 09:25 EDT, Allan Godding CLA
no flags Details | Diff
Patch for relengtools (46.57 KB, patch)
2007-10-09 10:46 EDT, Allan Godding CLA
no flags Details | Diff
patch (50.55 KB, patch)
2007-10-10 13:49 EDT, DJ Houghton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-01-16 09:56:33 EST
While the "Team > Release" action allows selecting a custom mapfile project (remembered across multiple invocations through DialogSettings in the wizard), the actions "Replace with > Released" and "Compare with > Released" always search the mapfile in the default mapfile project, "org.eclipse.releng" only. 

This makes this functionality hard to use for projects other than Eclipse Platform, which store their mapfiles in other projects.

I found following workarounds 
* Patch the org.eclipse.releng.tools/tools.jar/messages.properties file
  --> The key to change is RelEngPlugin.1=org.eclipse.releng
* Create a new project named "org.eclipse.releng" and add a folder "maps"
  as a linked resource, being linked to the real maps folder. I tested this
  only quickly, and it seems to work though it may be risky since CVS is
  not operational below the linked resource folder.

Both workarounds are somewhat awkward, and I'd like to see a real solution. I could imagine any of the following:
(1) Add an action "Set as default mapfile project" which allows the user to 
    select the actual mapfile project and set it as the default - the default
    should be remembered
(2) Add a Preference Page for releng.tools, with a Preference setting for the
    "default mapfile project" and "default mapfile folder"

Suggestion (1) seems to be least effort.
Suggestion (2) seems to be a little cleaner.
Comment 1 Allan Godding CLA 2007-10-01 09:45:45 EDT
Created attachment 79476 [details]
Patch for relengtools

Added a preference page for setting the desired map project.  Compare, Replace, and Release now all use the same dialog for selecting map project.
Comment 2 Allan Godding CLA 2007-10-01 13:34:26 EDT
Created attachment 79498 [details]
Patch for relengtools

Fixed some deficiencies found in the previous patch.
Comment 3 Allan Godding CLA 2007-10-01 14:55:22 EDT
Created attachment 79504 [details]
Patch for relengtools

Fixed some deficiencies found in the previous patch.
Comment 4 DJ Houghton CLA 2007-10-01 15:35:19 EDT
Created attachment 79508 [details]
patch for releng.tools

Here is an updated patch. Allan, please integrate the Release... action with the new code.
Comment 5 Allan Godding CLA 2007-10-03 11:04:26 EDT
Created attachment 79641 [details]
Patch for relengtools

Updated patch.
Comment 6 Allan Godding CLA 2007-10-05 10:55:33 EDT
Created attachment 79813 [details]
Patch for relengtools

Another updated patch.
Comment 7 Allan Godding CLA 2007-10-09 09:25:31 EDT
Created attachment 79949 [details]
Patch for relengtools

Updated to compile properly with Java 1.4
Comment 8 Allan Godding CLA 2007-10-09 10:46:01 EDT
Created attachment 79957 [details]
Patch for relengtools

Updated patch.
Comment 9 DJ Houghton CLA 2007-10-10 13:49:39 EDT
Created attachment 80079 [details]
patch

Looks good. Here is a slightly modified patch. 
Sonia, please review and release. 
Thanks.
Comment 10 Sonia Dimitrov CLA 2007-11-02 16:35:52 EDT
Patch applied and released for the next builds.  Thanks guys!
Comment 11 Martin Oberhuber CLA 2007-11-13 12:49:38 EST
Since I first see this in I20071107-1300, I suppose it's going into 3.4M4.

Just one suggestion -- the Prefs page is now 
  (Root) -> Map Project Selection
which is not quite where I had expected it. What about putting this in
  (Root) -> Team -> Releng Map Project Selection

Since the associated actions are all Team-support related, e.g.
  Team > Release
  Replace with > Released
  Compare with > Released

Apart from that, I find this really helpful -- thanks!!!
Comment 12 DJ Houghton CLA 2007-11-14 12:47:09 EST
Thanks, Martin. I have opened bug 209840 to address moving the preference page to a more logical category.