Community
Participate
Working Groups
Such as java editor does ))) That's more consistent and I should spend less time customizing workbench
-1. I think it should use dialog fonts like PDE editors.
-1 too. The problem is that text editor uses by default a monospaced font, which is good for code, but not for general text (at least on Eclipse workbench context). My case is worse, because I use "Bitstream Vera Sans Mono" - 11, which looks very big. It looks very good for code, but on task editor it looks odd because you get into a mix of big fonts for comments and dialog fonts for the others.
It's OK to use dialog font that's used by other workbench editors - why define custom font???
We had a fair amount of back-and-forth on this, and here is what was concluded: * Deriving from text editor leads to a less readable editor for the reasons Willian mentions. We used to have this as the default, and both the density and readability appear better when it is a dialog-based font, and more people seem to prefer it. * Using the default dialog font ("org.eclipse.jface.dialogfont") is a problem because it is too small. So we force the dialog font to be slightly larger on the typical setup by specifying "Tahoma-regular-10". If anyone knows of a way to specify the equivalent of "org.eclipse.jface.dialogfont,size=+1" or even "org.eclipse.jface.dialogfont-10" (to avoid specifying Tahoma, which I think always falls back to something reasonable) that would be better, but I'm not sure this is possible. Until we have a clear way to improve on this I'll close the bug Dmitry: could you post a screenshot of what the default font looks like on a Mac?
I remember that I suggested in some bug that it is possible to specify platform-specific overrides. Dmitry, if you can suggest a good default for macos (and screenshot please), I believe Mik can set it out-of-box.
Created attachment 57248 [details] task editor on mac
Thanks for the screenshot Dmitry. The fonts in that editor definitely do not look good enough. What I want to happen by default is for every font visible in the editor to be the same typeface and size, and for the title/section fonts to be bold (as they currently are). If you would like to provide a Mac-specific override please create a patch, and I would be happy to add it. It seems like on the Mac, which has a large dialog font by default, a fine override may be simply the following. However, this should be tested on a Mac. <fontDefinition ... id="org.eclipse.mylar.tasklist.ui.fonts.task.editor.comment" defaultsTo="org.eclipse.jface.dialogfont"/> Also see: * http://wiki.eclipse.org/index.php/Mylar_Contributor_Reference#Workspace * http://help.eclipse.org/help32/index.jsp?topic=/org.eclipse.platform.doc.isv/reference/extension-points/org_eclipse_ui_fontDefinitions.html
Created attachment 57286 [details] Now it's much better )))
That looks way better. Could you provide a patch to share this niceness with others?
Mik, You've changed plugin.xml of org.eclipse.mylar.tasks.ui (1.186 -> 1.187) so it has font "org.eclipse.jface.dialogfont-10"; I think that Eclipse fails to recognize this and fallbacks to some default - dialogfont I guess )))
Created attachment 57335 [details] font override Here I set Tahoma10 on win32; other platforms use default font.
Actually Eclipse for Mac sets -Dorg.eclipse.swt.internal.carbon.smallFonts property in eclipse.ini by default so this adds another configuration dimension ((( Second screenshot shows default font in task editor without -Dorg.eclipse.swt.internal.carbon.smallFonts but default font looks good in both cases.
Mik, Dmitry raised a interesting point, instead of making "Tahoma" the default and overriding to "dialogFont" on mac, wouldn't be better to make the "dialogFont" default and "Tahoma" a override on win32? It is because I think "Tahoma" is a windows-only font. It also would be interesting to know how a default of "dialogFont" appears to linux-gtk/motif (BTW, how does "Tahoma" appear on linux?).
Patch applied, thanks Dmitry! Willian: yes, Dmitry's patch took the better approach of specifying the font for Windows only. This means that we should still verify the default behavior on Linux, but no longer have to worry about how lack of Tahoma will fall back to another font.
