Bug 170385 - [correction] Quick Fix autocomplete should remember listbox size
Summary: [correction] Quick Fix autocomplete should remember listbox size
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
: 209024 218089 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-01-13 07:53 EST by Geert Poels CLA
Modified: 2010-11-10 10:41 EST (History)
4 users (show)

See Also:

Attachments
Fix (6.69 KB, patch)
2010-11-09 12:32 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geert Poels CLA 2007-01-13 07:53:18 EST 
Build ID: 3.2.1

Steps To Reproduce:
1.Write a line of code with errors.
2.Quickfix icon will appear
3.Click the icon and a list of suggestion fixes will appear
4.Enlarge the list to read the whole text
5.Repeat this steps a second time and notice that the list still has the same size
6.This is not the case with the code complete where a resize is remembered

(by default, a lot of times, the width is too small)


More information:
Comment 1 Dani Megert CLA 2008-02-12 06:29:22 EST 
*** Bug 218089 has been marked as a duplicate of this bug. ***
Comment 2 Markus Keller CLA 2010-03-26 07:08:54 EDT 
For the Java content assist proposals popup, this is implemented in
JavaSourceViewerConfiguration#getContentAssistant(ISourceViewer) which calls
ContentAssistant#setRestoreCompletionProposalSize(..)

We should do the same in JavaSourceViewerConfiguration#getQuickAssistAssistant(ISourceViewer), but there, the QuickAssistAssistant is missing API that forwards setRestoreCompletionProposalSize(..) to its internal QuickAssistAssistantImpl.
Comment 3 Dani Megert CLA 2010-08-11 07:46:03 EDT 
*** Bug 209024 has been marked as a duplicate of this bug. ***
Comment 4 Markus Keller CLA 2010-11-09 12:32:55 EST 
Created attachment 182734 [details]
Fix

Patch implements comment 2 by adding the missing link to store the size in the same fashion as content assist (each client has to provide its own dialog settings). Dani, please speak up if you disagree.
Comment 5 Markus Keller CLA 2010-11-10 10:41:25 EST 
Fixed in HEAD.