Bug 170321 - [Commands] Sometimes empty directories are not added by replace with latest
Summary: [Commands] Sometimes empty directories are not added by replace with latest
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-01-12 09:47 EST by Bruce CLA
Modified: 2019-09-02 13:06 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bruce CLA 2007-01-12 09:47:52 EST
Build ID: M20060921-0945

Steps To Reproduce:
1. Enter the following in plugin_customizations.ini
org.eclipse.team.cvs.ui/pref_prune_empty_directories=false

2. Add empty folders to a project in a CVS branch. Note: It is important that you do not use the main/head CVS branch. 

3. Checkout the project. The empty folders should not exist in the workspace. The setup is incorrect if you have the empty folders in your workspace. If you used the main CVS branch, you will see the folders in your workspace at this point. 

4.Prune Empty Dirs initially unchecked --> Replace with Latest does not give me the empty dirs **Problem**

5. Prune Empty Dirs checked, Apply     --> Replace with Latest does not give me the empty dirs **OK**

6. Prune Empty Dirs unchecked, Apply --> Replace with Latest DOES give me the empty dirs. **OK**


More information:
You may have to try this multiple times to recreate the problem. 

We had 4 people test this with a fresh install of Eclipse 3.2.1. Two people saw the problem immediatly. Two people experienced no problem.
Comment 1 Michael Valenta CLA 2007-01-12 10:00:38 EST
Are you working on a branch. If so, see bug 159490 comment 9 and 10. Could the people who don;t see the problem be on HEAD and the people who do be on a branch?
Comment 2 Bruce CLA 2007-01-12 13:03:10 EST
Yes, we are working on a branch. Bug 159490 is a BIRT bug. You must have meant to reference a different bug. 

Everyone checked out the same project in the same branch. 
Comment 3 Michael Valenta CLA 2007-01-12 13:15:12 EST
Sorry about that. Anyway, the CVS spec states that pruning should always occur when working against a branch or version.

*** This bug has been marked as a duplicate of bug 159480 ***
Comment 4 Bruce CLA 2007-01-12 13:21:20 EST
Mike,

I remember Bug 159480. This is different.

The problem is that "Replace with latest" from branch does not work occasionally. See step 4 below. 
Comment 5 Michael Valenta CLA 2007-01-12 14:11:35 EST
Step 4 says that Replace with latest doesn't give you the empty directories. If you are performing a Replace on a branch, I wouldn't expect it to give you the empty directories. Did you mean to say Replace with Latest from HEAD?
Comment 6 Bruce CLA 2007-01-12 14:24:37 EST
It is confusing. I did mean to say "Replace with latest" from branch. In fact, that does add the empty directories to your workspace. When we upgraded to 3.2.1, we found that sometimes you have to toggle the "Prune empty directories" preference twice to make "Replace with latest" from branch work. 
Comment 7 Michael Valenta CLA 2007-01-12 14:40:57 EST
OK, I see. So either Replace with latest on a branch should add empty directories (in which case point 4 is the problem) or it should never add empty directories, (in which case, point 6 is the problem). To solve this problem properly, the best approach would be to see what the command line client does when performing a "cvs update -P -C" on a branch and have Eclipse work the same way (although, if it turns out CVS always prunes on a branch, it wouldn't hurt to have a preference that didn't prune on a branch).

Unfortunately, we do not have the manpower to address this issue in 3.3. Contributions are welcome.
Comment 8 Bruce CLA 2007-01-12 14:48:28 EST
I would say that case point 4 is the problem. If "prune empty directories" is false and you "Replace with the latest" from CVS you should get the empty directories. 
Comment 9 Eclipse Genie CLA 2019-09-02 13:06:08 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.