Bug 170305 - [Wizards] new extension points for commit operation
Summary: [Wizards] new extension points for commit operation
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.2.1   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2007-01-12 04:55 EST by Christian Plaetzinger CLA
Modified: 2019-09-06 16:09 EDT (History)
2 users (show)

See Also:


Attachments
Changed and new resources (18.25 KB, application/x-zip-compressed)
2007-01-12 05:02 EST, Christian Plaetzinger CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Plaetzinger CLA 2007-01-12 04:55:12 EST
we faced a problem when we tried to connect eclipse with our own bug tracking tool. We wanted to catch all commited resourses and be able to change/propose the commit comment. But we did not find any matching extension point for this. Therefore we changed the source of CommitWizard and CommitWizardCommitPage in package org.eclipse.team.internal.ccvs.ui.wizards. We also created two new extension points with allows the plugin to get notified about all commit operations and contribute to the commit comment. 

During our analyse of available extension points we got the impression that other people could use this extension too. Therefore we would like to contribute our changes to the Eclipse CVS project.
Comment 1 Christian Plaetzinger CLA 2007-01-12 05:02:54 EST
Created attachment 56817 [details]
Changed and new resources
Comment 2 Michael Valenta CLA 2007-01-12 08:06:42 EST
Thanks for the contribution. Here are some comments:

1) Could you reattach the contribution in the form of a patch? That way it will be easier to ensure that changes made to HEAD since you made changes will not be lost (and also makes it easier to browse the patch to inspect changes).

2) Any new files require a copyright. The easiest approach is to take the file header from an existing file and change the contributing company as appropriate. You will also want to add a contribution line to any modified files.

3) Could you add documentation to the scheme files describing the purpose of the extension and how a client should use it.

4) Eclipse convention is to start interfaces with I (e.g. ICommitCommentContributor).

Due to comment 1, I haven't done a thorough inspection of the code. I will perform a more in depth inspection once the contribution is in patch form.

Comment 3 Eclipse Webmaster CLA 2019-09-06 16:09:57 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.