Bug 170140 - Need new API to replace "Plugin" references
Summary: Need new API to replace "Plugin" references
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
: 292712 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-01-10 17:09 EST by DJ Houghton CLA
Modified: 2009-11-03 04:54 EST (History)
4 users (show)

See Also:

Attachments
Proposal v01 (6.73 KB, patch)
2009-10-30 06:55 EDT, Szymon Brandys CLA 		no flags Details | Diff
Proposal v02 (12.95 KB, patch)
2009-10-30 12:05 EDT, Szymon Brandys CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2007-01-10 17:09:35 EST 
Currently there is some API related to SaveParticipants which take a Plugin object as a parameter. We should look into deprecating this and creating equivalent API which accepts a Bundle.
Comment 1 Szymon Brandys CLA 2008-04-14 04:20:26 EDT 
Lowering the priority to better match reality.
Comment 2 John Arthorne CLA 2009-10-19 18:06:52 EDT 
*** Bug 292712 has been marked as a duplicate of this bug. ***
Comment 3 John Arthorne CLA 2009-10-19 21:37:23 EDT 
Raising priority, as noted in duplicate bug the API can't be used without using the Plugin class which is mostly obsolete and replaced by Bundle. We shouldn't be forcing people into using obsolete classes.
Comment 4 Szymon Brandys CLA 2009-10-30 06:55:48 EDT 
Created attachment 150911 [details]
Proposal v01
Comment 5 John Arthorne CLA 2009-10-30 10:38:48 EDT 
The API approach using a string looks good (String will never be deprecated ;). There are a few more places in SaveManager that reference the saveParticipants field that will also need fixing up.
Comment 6 Szymon Brandys CLA 2009-10-30 11:00:03 EDT 
(In reply to comment #5)
> There are a few more places in SaveManager that reference the saveParticipants
> field that will also need fixing up.

Right. I marked the latest patch as obsolete, when the resource tests started to glow red. I'll attach the fixed patch in a moment.
Comment 7 Szymon Brandys CLA 2009-10-30 12:05:26 EDT 
Created attachment 150945 [details]
Proposal v02
Comment 8 Szymon Brandys CLA 2009-11-02 05:10:08 EST 
Proposal v02 released to HEAD.
Comment 9 Markus Keller CLA 2009-11-02 12:39:03 EST 
The fix in HEAD causes API errors in my workspace (with a 3.5 baseline).
Comment 10 Szymon Brandys CLA 2009-11-03 04:54:37 EST 
(In reply to comment #9)
> The fix in HEAD causes API errors in my workspace (with a 3.5 baseline).

Thanks Markus.

My 3.5 baseline is Eclipse SDK 3.5.1 installed via p2Agent. Something wrong happened to the profile and it probably didn't contain all the plug-ins. Thus I couldn't see the API tooling problems. This was a problem with p2Agent not API tooling. I fixed my profile and I am not able to reproduce this issue now.

John already fixed the API tooling problems.