Bug 169 - Property page fails silently when disconnected (1GF9HEQ)
Summary: Property page fails silently when disconnected (1GF9HEQ)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 M6   Edit
Assignee: Jeff Brown CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 21:37 EDT by John Arthorne CLA
Modified: 2017-09-18 01:41 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2001-10-10 21:37:34 EDT
VCMPropertyPage tries to contact the server before control is created

in VCMPropertyPage#createControl, the call to initialize() should come after
the call to setControl().  Otherwise, if errors occur during initialize (for example
if the server is down), it has no way of opening an error dialog because it has no parent control yet.

NOTES:

JohnA (6/13/2001 9:38:28 AM)
	Recommend deferring.  Behaviour is not bad (no error shown to user, but an error is logged,
	the property page shows the last known values for base, common, remote).
Comment 1 Kevin McGuire CLA 2002-04-17 16:56:16 EDT
Behaviour now is you get a not obvious error - "Cannot create part: Properties".

Closing the properties page also generates an error.
Comment 2 Jeff Brown CLA 2002-04-18 18:42:54 EDT
Remark: In Team 2.0, this functionality is assumed by CVSRemote[File/Folder]
PropertyPage.
Comment 3 Jean-Michel Lemieux CLA 2002-04-22 12:41:57 EDT
Fix released to HEAD.
Comment 4 Eclipse Genie CLA 2017-09-17 23:39:03 EDT
GitHub Pull Request 274 created by [cxbrooks]
https://github.com/eclipse/triquetrum/pull/274
Comment 5 Eclipse Genie CLA 2017-09-18 01:41:00 EDT
GitHub Pull Request 275 created by [cxbrooks]
https://github.com/eclipse/triquetrum/pull/275