Comment 1 Brian Bauman 2006-12-14 11:09:01 EST

I think we may all be surprised :)

Comment 2 Chris Aniszczyk 2008-01-15 16:10:03 EST

I don't like this bug but we should do something in 3.4M5 to be more consistent with JDT and the API tools.

Comment 3 Michael Rennie 2008-01-15 17:08:59 EST

Created attachment 86986 [details]
patch

here is a patch that cleans up the pref and prop page to LAF like the JDT / API Tools pages.

Comment 4 Chris Aniszczyk 2008-01-15 18:00:13 EST

This doesn't have the little collapsible goodness as the JDT/API Tools page. The point of the rework was to kill those evil tabs :(

Comment 5 Chris Aniszczyk 2008-01-15 18:01:03 EST

adding context

Comment 6 Chris Aniszczyk 2008-01-15 18:01:13 EST

Created attachment 86993 [details]
mylyn/context/zip

Comment 7 Chris Aniszczyk 2008-01-15 19:54:23 EST

I'm going to commit the first wave of this patch as a start. It does fix an issue with spacing that we had :)

I still don't like those tabs but I'm not sure a better approach would be those collapsible boxes... maybe a mix of both is the right way to do it.

Comment 8 Michael Rennie 2008-02-12 13:51:54 EST

I think you should keep the tabs, and if needed, break up the listing of options into reasonable groupings using the twisties (the collapable boxes).

Chris, if you can come up with a reasonable breakdown for groupings I will redo the page to look like the api tools errors/warnings page

Comment 9 Michael Rennie 2008-02-12 13:54:43 EST

Created attachment 89533 [details]
example

Example of what I mean by keeping the tabs but breaking up the options (the api tools error/warning page).

Comment 10 Chris Aniszczyk 2008-02-15 11:12:53 EST

How about put everything under General for now with the exception of maybe the Plug-ins page where there will be three categories for now:

General
(everything else)

Deprecation
(usage of deprecated....)

Internationalization
(Usage of non-externalized strings)

I think once we have something there... it will be easier to expand... I assume you will use the PropertyAndPrefrencePage from JDT?

Comment 11 Chris Aniszczyk 2008-02-15 11:13:45 EST

Thanks for looking into this Mike... the problem of our compilers page has plagued PDE for a long time, with this step, we will be closer to moving in the right direction :)

Comment 12 Michael Rennie 2008-04-16 14:42:57 EDT

Created attachment 96306 [details]
patch

this patch completely converts the 'old' prefs to the 'new' style (shared by API tools and JDT), and provides the fancy twisties for the plugins page.

Comment 13 Michael Rennie 2008-04-16 15:31:12 EDT

Created attachment 96320 [details]
updated patch

tiny update to ensure the pref page is parented properly when opened from the property page

Comment 14 Chris Aniszczyk 2008-04-16 16:48:01 EDT

Thanks Mike. I'll look at this once I finish some p2-related work.

This should make it into the next i-build and many people will be joyful. It brings tears to my eyes to see this page finally redone.

Comment 15 Chris Aniszczyk 2008-04-17 14:45:39 EDT

wow... thanks Mike... this is one of the greatest patches I've seen in awhile.

Well documented code... even with help contexts, updated copyrights... wow... no bugs wih testing...

Thanks!

> 20080417

Comment 16 Chris Aniszczyk 2008-04-17 14:45:46 EDT

Created attachment 96486 [details]
mylyn/context/zip

Comment 17 Michael Rennie 2008-04-22 16:49:06 EDT

verified