Community
Participate
Working Groups
Build ID: M20060921-0945 Steps To Reproduce: 1) make change to resource 2) commit the changes, causing the commit wizard to appear 3) try to pick a previously used message, none appear More information: this occurs for me on os x - i tried a fresh install of eclipse, but the problem still appears.
This problem is usually due to a permissions problem. Make sure that the file at the location <your workspace folder./.plugins/org.eclipse.team.cvs.ui/commitCommentHistory.xml is writtable.
Created attachment 55857 [details] screen shot i checked the permissions - they are correct and i see the entries being written to the xml file, but they don't appear w/in the UI (i've attached a screen shot) - perhaps this needs to be re-assigned?
That's very odd. Is there anything in your error log?
Created attachment 55867 [details] comment history
not that i can see - i've attached the comment history xml file in case there is something screwy going on there.
sorry for the spam... after looking at the xml file, i notice the comments aren't stored in CDATA blocks, so i'm thinking something in there is breaking the xml parsing. i can confirm this by deleting the comment history file, committing a resource w/ a simple message "test", and then attempt to commit another resource and click the drop down - the previous message appears.
So, are you saying that now it is working for you? I tried your file on windows but it works for me there.
yes and no :) any commit comments that i prefix w/ a '-' do not appear in the previous list drops down. if the comment doesn't start w/ a '-', the comment appears. i'm not sure if this is mac specific or not. i do notice that where the comment should be in the drop down list is a 'beveled' line that goes all the way across the drop down - you can see this in the screen shot.
i see this has the 'helpwanted' tag now, so i'm guessing there isn't any rush to fix this. it seems that wrapping the commit messages inside a CDATA block would resolve these issues. i do notice this same behavior using the subclipse plugin as well, so i'm thinking that there is some shared piece of code responsible for this. i'd be willing to submit a patch to fix this issue if 1) the proposed CDATA solution is acceptable and 2) if someone could point me in the general direction of the code responsible for writing/reading the 'commitCommentHistory.xml' history file.
The class that handles the comment serialization is the RepositoryManager in the org.eclipse.team.cvs.ui plug-in. It makes use of an XMLWrite class in the same plug-in. Using a CDATA is fine with me. The only requirement is that the old format must still be readable so that comment history is preserved across an upgrade.
it looks like this has auto-resolved itself as of the 3.4M3 milestone release.
Affirmative, it works for me in I20071101-2000 on Mac OS X.
