Bug 167173 - [PATCH] Build swt 3.2.1 on FreeBSD
Summary: [PATCH] Build swt 3.2.1 on FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.2.1   Edit
Hardware: Other Unix All
: P3 enhancement (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Grant Gayed CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-12-07 17:10 EST by Diego Pettenò CLA
Modified: 2006-12-21 11:41 EST (History)
2 users (show)

See Also:

Attachments
swt-3.2.1-fbsd.patch (2.49 KB, patch)
2006-12-07 17:12 EST, Diego Pettenò CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pettenò CLA 2006-12-07 17:10:55 EST 
Building swt 3.2.1 on FreeBSD with vanilla sources fails, as it does not support that platform at the moment.

I'm attaching a patch that will allow to build it, using (cleaned up) patches from FreeBSD ports.

To apply, copy make_linux.mak in make_freebsd.mak and then apply the diff.

HTH,
Diego
Comment 1 Diego Pettenò CLA 2006-12-07 17:12:10 EST 
Created attachment 55278 [details]
swt-3.2.1-fbsd.patch
Comment 2 Steve Northover CLA 2006-12-20 19:27:29 EST 
We should just put these changes makefile in (despite the fact that we don't have a Free BSD machine).  We don't need to add the variable to OS because it is never used.
Comment 3 Grant Gayed CLA 2006-12-21 11:41:58 EST 
fixed > 1221, applied the build.sh change and makefile addition.

No change was made to the OS.java class because an isFreeBSD field would never be referenced in swt since it is not supported.  At present the is* fields are not referenced in swt anyways as there is no OS-specific swt-gtk code.