Bug 166763 - [Undo] API request: org.eclipse.ui.internal.ide.undo.ResourceDescription
Summary: [Undo] API request: org.eclipse.ui.internal.ide.undo.ResourceDescription
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2006-12-05 05:19 EST by Markus Keller CLA
Modified: 2007-02-06 10:21 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-12-05 05:19:17 EST 
I20061129-1340

To support undo for file operations in the Package Explorer, we need the functionality of org.eclipse.ui.internal.ide.undo.ResourceDescription. Could this class be promoted to API?

I've copied the package for now (to avoid referencing internal code). We need more low-level operations than what's currently in org.eclipse.ui.ide.undo, because we must let jdt.core do the actual modifications and because our actions are refactorings with participants, which must adhere to the ltk.core.refactoring undo story.
Comment 1 Markus Keller CLA 2007-01-03 04:48:17 EST 
This should be resolved before the API freeze.
Comment 2 Susan McCourt CLA 2007-01-08 15:21:17 EST 
cc'ing Tod.
I am on leave right now, but saw this go by.
Will be back in mid-Feb...when is API freeze?  I can try to look at this before my return if necessary.
Comment 3 Kim Horne CLA 2007-01-08 15:33:46 EST 
Susan: I was going to take a look at this sometime this week.  Shall I hold off?
Comment 4 Tod Creasey CLA 2007-01-09 09:24:30 EST 
Kim please have a look at this
Comment 5 Kim Horne CLA 2007-01-09 11:25:53 EST 
Fix in HEAD.  In order to avoid exposing the subclasses or a "parent" setter I've had to introduce a new baseclass called AbstractResourceDescription in the internal package.  It contains all of the implementation that was in the original ResourceDescription except for the statics and the public baseclass now contains nothing but abstract methods and the statics.
Comment 6 Markus Keller CLA 2007-01-10 05:05:01 EST 
Thanks, works great.
Comment 7 Kim Horne CLA 2007-02-06 10:21:05 EST 
Verified in source in I20070206-0010