Bug 1663 - Missing toString() feature makes debugging painful (1GH3W9P)
Summary: Missing toString() feature makes debugging painful (1GH3W9P)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 1522 1664 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:17 EDT by Jerome Lanneluc CLA
Modified: 2001-11-01 12:20 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2001-10-10 22:17:11 EDT
The compiler uses char arrays instead of Strings. char arrays don't print nicely. 
	That's why we have these nice toString() methods to help us debugging. 
	The VA/Java debugger used to show them. The Eclipse debugger doesn't which 
	makes debugging the 	compiler very painful.

NOTES:
Comment 1 Darin Wright CLA 2001-10-17 10:17:47 EDT
*** Bug 1522 has been marked as a duplicate of this bug. ***
Comment 2 Darin Wright CLA 2001-10-17 10:20:16 EDT
*** Bug 1664 has been marked as a duplicate of this bug. ***
Comment 3 Darin Wright CLA 2001-10-23 21:43:42 EDT
This is the presentation that has been agreed upon:

* The variable view will contain a split pain with two viewers.
* The first view is the variable tree view (as today)
* The second view is a text view to display the 'toString()' of
  the selected variable.
* A preference will control if the split is horizontal or vertical
* The text view will be known as the 'detail area', and the 
  variable view will support hide/show of details (with a toggle
  button in the toolbar)
* By default, the detail area is hidden
* The IDebugModelPresentation has been extended to support retrieval
  of detail for a value (#getDetail(IValue)).
* When a variable is selected and the view is showing details,
  the debug model presentation for the appropriate debug model
  is queried to populate the detail view
* the detail area will (at first) be a read only viewer that supports
  find & copy
* I made a first cut of the implementation of #getDetail(IValue) for
  the JDIDebugModelPresentation
Comment 4 DJ Houghton CLA 2001-10-24 06:37:46 EDT
PRODUCT VERSION:
	R0.9

Comment 5 Joe Szurszewski CLA 2001-11-01 11:53:10 EST
Implemented.  Added TextViewer to VariablesView separated by sliding sash from 
variables tree.  Added toggle action to toolbar to show/hide detail pane 
(current icon is borrowed from help.ui, we need a better icon, and one that has 
disabled and hover versions as well).  Added Copy & Find actions to context 
menu for detail pane.  Verified that context menus for tree viewer pane and 
detail pane can be contributed to independently.  Added preference to debug 
preferences to control orientation of detail pane, choices are underneath or to 
the right of the tree veiwer pane.
Comment 6 Joe Szurszewski CLA 2001-11-01 12:00:14 EST
There are several outstanding issues yet:
  -  the detail pane always has scroll bars, whether needed or not,
     bug #5366 filed for this.
  -  the sash has a flat, not 3D look.  Only way to get a 3D look is to
     put borders on the widgets it separates, which looks wrong.  Filed
     bug #5371 for this.
  -  Need a real icon for the ShowVariableDetailPaneAction.

Please verify.
Comment 7 Darin Wright CLA 2001-11-01 12:16:03 EST
Other issues:
- need ability adjust split from vertical to horizontal (see drop down triangle 
menu on class hierarchy viewer as example) (#5422)
- need pretty printers for Arrays (bug #1745)
- detail area does not refresh (for example, while stepping through code that 
adds elements to a Vector, the toString() area does not update, but the 
variables view tree does update. (bug #5421)
Comment 8 Darin Wright CLA 2001-11-01 12:20:56 EST
Added artwork requests to bug #4383.