Bug 16574 - [ExternalTools] External tool builders should use same set of external tools
Summary: [ExternalTools] External tool builders should use same set of external tools
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 major (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui, usability
Depends on:
Blocks:
 
Reported: 2002-05-21 11:02 EDT by John Arthorne CLA
Modified: 2002-12-04 11:07 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2002-05-21 11:02:20 EDT
Build 20020521

This is best explained by example:

1) From the Run menu, select External Tools -> Configure
2) Define some external tool, say a batch file in the filesystem
3) Now select a project, and go to the external tool builders property page.

-> There should be a button to add the existing external tool that I defined in 
step 2.

4) Define some external tool builder, for example "javac.exe"
5) Now go back to Run->External Tools->Configure

-> I should see the "javac" external tool that I configured in step 4).

6) Select another project, and go to the external tool builders property page.

-> It should be very easy to add the same builder on this project that was 
created in step 4).  

I.e., there should be one pool of known external tools that can be run once from 
the run menu or added to a project as a builder.
Comment 1 Adam Schlegel CLA 2002-05-24 13:14:29 EDT
If this were to be implemented, I would like to see the External Tool Builders 
properties page look similar to the Customize Toolbar dialog in Internet 
Explorer. The dialog provides an intuative interface for adding a builder from 
a list of pre-defined ones, plus changing the order of the existing builders.
Comment 2 Simon Arsenault CLA 2002-05-29 10:20:52 EDT
Defer until after release 2.0

There is not enough feedback yet to suggest this is something users will want. 
To implement this is too much this late in release cycle (tools used in the 
build process are stored in the .project file while global run tools are stored 
in the plugin dir - trying to sync up those and somehow alerting the user about 
changes to a tool that is also used as builder). Maybe there could be an option 
to copy a tool from the global list to be a builder?
Comment 3 Simon Arsenault CLA 2002-09-06 14:39:56 EDT
In the new external tool work, we will be providing an "add" button which you 
can pick existing tools and add them as a builder.

Note: new external tool work is not yet released to the head stream and won't 
for a while yet.
Comment 4 Jared Burns CLA 2002-09-27 15:06:27 EDT
This has not been fixed and should not have been closed.
Comment 5 Darin Wright CLA 2002-11-15 10:14:23 EST
As we are using launch configs, this is now under consideration. The trick is 
that the launch config has to be shared in order to "share" the tool as a 
builder.
Comment 6 Jared Burns CLA 2002-12-03 19:07:59 EST
Implemented.

Added a "Copy..." button that allows the user to choose an existing external
tool launch config. The config is then copied to a new config in the project
and added as a builder. Also created an extension point to allow external 
tool extenders to specify the type of configuration that should be created
when copying a config.

The extension point is useful for the case where an extender has seperate
configuration types for "normal" configs and for project builders. The
Ant support and external program support defines separate builders like
this to allow us to customize the UI for configuring project builders.

Please verify.
Comment 7 Darin Wright CLA 2002-12-03 23:10:35 EST
I have programs defined as tools in my workspace, but they do not appear in the 
dialog as potential configs to copy.
Comment 8 Jared Burns CLA 2002-12-04 10:56:35 EST
Fixed. I was using the wrong constant to access the external tool configs 
(yikes!). Please verify.
Comment 9 Darin Wright CLA 2002-12-04 11:07:00 EST
Verified.