Bug 165479 - [Preferences] PropertyDialog doesn't persist resize
Summary: [Preferences] PropertyDialog doesn't persist resize
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks: 132081
  Show dependency tree
 
Reported: 2006-11-22 12:26 EST by Brian Fitzpatrick CLA
Modified: 2009-08-30 02:09 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Fitzpatrick CLA 2006-11-22 12:26:44 EST
Hi. We're attempting to use the PropertyDialog from a DTP action to pop up the properties for a variety of items in the Data Source Explorer. The PropertyDialogAction doesn't quite do what we need it to do, as it isn't supplying all the pages we'd like based on the selection. But the issue with the dialog is that it's not persisting its dialog settings as it should. 

getDialogBoundsSettings() returns null, so it doesn't persist the size and other settings. 

This is a blocking issue for us for another bug (132081). We don't want to have to extend an internal dialog just to persist the size. 

It might be nice if there was a public property dialog we could use, extend, and stash the dialog settings for. But we are open to other suggestions.
Comment 1 Tod Creasey CLA 2006-11-24 08:44:35 EST
This is actually by desingn - we don't want to force a size that may be inappropriate for the property page - we always try and use the size given to us.

The only time the size changes otehrwise is if the user resizes. Are you trying to persist a user's resize? If it is an issue with your page resizing you can fix how computeSize works on your page.

Can you explain your use case? We would need a very strong reason to change this behaviour as many people rely on it.
Comment 2 Brian Fitzpatrick CLA 2006-11-27 13:09:51 EST
Hi. I guess there are a couple of issues here... 

1) We would like to be able to reuse the internal property dialog, but can't because it's internal.

2) If we could extend it, we could provide our own handling of dialog resize by saving the dialog bounds settings in our extension of the dialog.

But our general use case is that we have properties on objects in the Data Source Explorer. We have our own view property action that brings up the property dialog to manage those object properties. 
Comment 3 Tod Creasey CLA 2006-11-27 14:14:01 EST
 Brian my point is that you can already do this by persisting the size for your property page so that when ask for the size of the page you get what you need.

That way there is no API change required by us and you get the behaviour you need.
Comment 4 Denis Roy CLA 2009-08-30 02:09:32 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.