Community
Participate
Working Groups
20020519 Win32 I have created a dummy subdirectory in the features/ directory that contained no feature.xml. At the same time I "touched" (made a dummy edit and saved) a real feature.xml in another feature subdirectory (to trigger change detection). On startup, reconciler processed the dummy subdirectory as a change (even though it has no feature.xml) and produces a delta. This triggered the "you've got changes" dialog showing <path>/features/<dummy dir>/(0.0.0) as the change. If a feature directory does not contain feature.xml IT IS NOT A FEATURE and should simply be ignored. Consider the case where we fail part way through the install. We must not flag the partial install (with feature999999.xml) as changes or errors on next startup.
When the plugin registry is loaded, the code makes a check for plugin.xml/ feature.xml as follows: InputStream is = null; try { is = manifest.openStream(); } catch (IOException e) { if (debug) debug("No plugin found for: " + manifest); return null; } // parse the xml file by passing it the stream // close the stream We need to do something similar .... ie. need to distinguish missing xml file from inability to parse.
Changed code in SiteFileParser to check for existence of feature.xml in directory. Checked scenario, the workspace opens but doesn't prompt the user fora new feature. The delat XML file is not created. The log shows the warning: !MESSAGE Install/Update WARNING:Unable to find feature.xml in directory:C:\SDK 0515\eclipse\features\org.eclipse.jdt_2.0.1
