Community
Participate
Working Groups
Version: 3.3.0 Build id: I20061102-0010 The Help fonts and colours appear to be hardcoded to blue so as a result are unreadable - they should use the constants for active and hypperlink colour. STEPS 1) Turn on High contrast 2) Open help - unreadable
Created attachment 53198 [details] screenshot
Did you restart Eclipse? If you do I think help will pick up the new colors as defined in JFaceResources.
I tried it but it didn't help.. still blue. This is not just help but seems to be all forms.
When you switch to High Contrast you get prompted to restart which I did.
Last time I checked, Forms use normal and active hyperlink colors from JFaceResources or some such. Did these values change after restart?
Yes - when you restart due to High Contrast change the themes change
JFace is still giving {0, 0, 128} even after restarting the workbench after switching to high contrast.
This is working if you completely shutdown and then restart but not with the High Contrast change restart
*** Bug 176381 has been marked as a duplicate of this bug. ***
I would like to request that the severity of this bug be raised to Major since it is considered an accessibility issue for our product release.
Am I understanding that this issue only presents itself immediately after a change into high contrast that isn't followed by a reboot? If this is the case I dont think it's too big a deal - people who need high contrast support wont just be switching into it, they'll be running with it consistently.
The bug record (Bug 176381) that was dup'd against this one does not have that limitation in our testing so either it should not have been dup'd or we are experiencing different results in our testing. I was able to reproduce this consistently with eclipse 3.3 by starting in HC mode and then launching eclipse.
Can we get the colors by creating just a link widget and asking it for it's foreground and background?
We will need support from SWT to be able to access these colors as they are currently not available through API. See Bug 181592
*** Bug 89373 has been marked as a duplicate of this bug. ***
Marking for 3.4. We will have to see what SWT can do about Bug 181592 before we can proceed on this.
Lowering priority to P3. This is a real bug, but it's not going to stop us from shipping. Changing severity to Major to capture the importance to the reporters.
*** Bug 57044 has been marked as a duplicate of this bug. ***
Removing the 3.4 tag as we need Bug 181592 to be resolved before we can move forward
Susan is now responsible for watching the [Themes] category.
Here is a snippet for calculating a second color that's darker from some original color: float scaleFactor = 0.7f; RGB rgb = new RGB(0, 102, 204); float[] hsb = rgb.getHSB(); hsb[2] *= scaleFactor; if (hsb[2] < 0) hsb[2] = 0; if (hsb[2] > 255) hsb[2] = 255; Color newColor = new Color(display, new RGB(hsb[0], hsb[1], hsb[2]));
Created attachment 226966 [details] Patch Here is a patch that will change the default JFace hyperlink color preferences to be keyed off the system hyperlink preference. This is a good thing as it means the default will now respect high contrast mode. It's easy to verify this on Windows: open the Help view, notice the link colors and then change to High Contrast mode.
Created attachment 226967 [details] Patch Updated the comments in the patch.
(In reply to comment #23) > Created attachment 226967 [details] > Patch Looks good. 1) could we switch the factory to ACTIVE_HYPERLINK_COLOR instead of HYPERLINK_COLOR? I don't mind if the active link is slightly lighter based on the factory. 2) Could we update org.eclipse.ui.forms.HyperlinkSettings.initializeDefaultForegrounds(Display) (in eclipse.platform.ua) so it uses COLOR_LINK_FOREGROUND as the fail-through default 3) we need to update o.e.ui.workbench and o.e.ui.forms to import an SWT of 3.101 (or whatever the 4.3 stream SWT is) since we use a new API constant) PW
Thanks Bogdan, and sorry I forgot to swap the author. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a6d95ae11b9b4967c998ffe8ad15fa43591e8034 PW
*** Bug 313396 has been marked as a duplicate of this bug. ***
The "if (hsb[2] > 255) hsb[2] = 255;" in RGBBrightnessColorFactory doesn't make sense. Fixed this bug, removed the harmful error swallowing and other bad coding style, and formatted the code: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ee57e66cde7637caf434dc4cbaa5b1362f022c85
Markus or Paul, would you be able to please backport this to R4_2_maintenance (and, if applicable, R3_8_maintenance)? All SWT API changes in bug 181592 have now been backported to R4_2_maintenance.
4.2.2+ http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=002687ba936980d91f14e4d128f09dbd6afbecf3 http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=96b71850c458247dc962fa4cf3fcbc308741f8ee 3.8.2+ http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_8_maintenance&id=b92bc48aa3f7e68b3fa524a6fc0bec591e9f4f06 http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_8_maintenance&id=511f057139919c0a206c7644b43722bd35d50a7e PW
