Bug 163150 - Usability - adding existing artifacts/locations to deployment should select by name (not filename)
Summary: Usability - adding existing artifacts/locations to deployment should select b...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2006-11-01 17:23 EST by Jeff Nevicosi CLA
Modified: 2016-05-05 10:29 EDT (History)
3 users (show)

See Also:


Attachments
Patch. (2.16 KB, patch)
2008-04-15 10:03 EDT, Paul Slauenwhite CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Nevicosi CLA 2006-11-01 17:23:21 EST
1) Create a location (for example, name it localhost... the file asset will be named localhost.location)

2) Rename this location (to "foo")

3) Create a deployment

4) Within the wizard, you are prompted to add a location  (and artifact, these steps are reproducible for those assets, as well).  Select Add at this page.

5) A new wizard with the title "Add Location Association" appears.  Select "Use existing resource" radio, click Browse.

6) A file selector appears with all available locations.  However, filenames are displayed, not the name   (localhost.location  which no longer corresponds with our location "foo")

This is reproducible with locations & artifacts.  This is reproducible via the Add buttons in the deployment editor.

Possible Resolutions:

1) Display names in the Browse dialog.  As it's possible that multiple locations can have the same name, perhaps a label like:  "Name (filename.file)"

2) Rename the file when the asset's name is changed.  I'm sure this would cause lots of other related problems, so this option is probably a bad idea.
Comment 1 Mark D Dunn CLA 2006-11-06 08:41:58 EST
Defer to 4.4. 
Comment 2 Mark D Dunn CLA 2007-01-16 16:44:33 EST
Add estimate.  Probably can be done quicker by a UI developer.
Comment 3 Paul Slauenwhite CLA 2007-01-26 08:25:26 EST
Targeting to future since not containable in 4.4.
Comment 4 Paul Slauenwhite CLA 2007-01-26 09:01:29 EST
As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4.  All other Test Project defects have been targeted to future.

If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org).  We will collectively triage and assess our resources to determine a case-by-case decision. 
Comment 5 Paul Slauenwhite CLA 2007-01-26 09:03:52 EST
Correction:  The Test Project mailing list is tptp-testing-tools-dev@eclipse.org.
Comment 6 Paul Slauenwhite CLA 2007-10-11 12:58:19 EDT
Duwayne, please provide a sizing.
Comment 7 Paul Slauenwhite CLA 2007-10-11 12:58:48 EDT
(In reply to comment #6)
> Duwayne, please provide a sizing.
> 

Sorry, I did not see the sizing.
Comment 8 Paul Slauenwhite CLA 2007-11-07 06:33:08 EST
Bulk update of the target field to reflect the change in iteration numbers.
Comment 9 Paul Slauenwhite CLA 2008-04-14 08:52:32 EDT
Jerome, I will take this one.
Comment 10 Bozier jerome CLA 2008-04-14 09:00:37 EDT
changes introduced with 155025 resolution :
. rename via contextual menu makes a name check (ok stay greyed if check fail). also, it changes both logical and physical name
. rename via editor makes a name check (resource is not saved and stay in dirty mode at save time if check fail). it only changes logical name

name chek policy (more detailled in doc attached to 166025) :
1. name can't be empty
2. name can't be the same as an existing physical resource
3. name can't be the same as an existing logical resource
4. name have to be changed (contextual menu only)

example :
 let's say we have a location named "A.location", with logical name equal to "C", and another location named "B.location" with logical name equal to "B"
 . in case of renaming of "B" via contextual menu (physical rename) :
    - if entered name is empty (rule 1), equal to "A" (rule 2), equal to "C" (rule 3) or equal to "B" (rule 4), the OK button stay greyed
    - any other name is allowed. example : rename to "D" will give "D.location" as physical name and "D" as logical one
 . in case of renaming of "B" inside the editor (logical rename only) :
    - if entered name is empty (rule 1), equal to "A" (rule 2), equal to "C" (rule 3), an error message appear at save time, save is not performed and editor stay into "dirty" state
    - any other name is allowed. example : rename to "D" will give "B.location" as physical name (unchanged) and "D" as logical one

all of this should cover 2nd of possible resolution



Comment 11 Bozier jerome CLA 2008-04-14 09:01:49 EDT
error in previous comment : all of this was introduced with resolution of 166025
Comment 12 Paul Slauenwhite CLA 2008-04-14 14:02:04 EDT
(In reply to comment #10)

Thanks Jerome.  This work improves consistency and usability in teh Test Perspective.

> - any other name is allowed. example : rename to "D" will give "B.location"
> as physical name (unchanged) and "D" as logical one

This is case that Jeff is concerned with, when the location/artifact has a different logical name (permitted), we are displaying the file name in the UI instead of the logical name.
Comment 13 Paul Slauenwhite CLA 2008-04-15 10:03:15 EDT
Since the Test Navigator uses the logical names of test assets without the file extension, we will consistently use logical names for test assets in all wizards.
Comment 14 Paul Slauenwhite CLA 2008-04-15 10:03:53 EDT
Created attachment 96072 [details]
Patch.
Comment 15 Paul Slauenwhite CLA 2008-04-15 10:04:50 EDT
Hours worked to create and test the patch.

Patch checked into CVS (HEAD).
Comment 16 Jeff Nevicosi CLA 2008-05-23 18:28:08 EDT
verified. closed.