Community
Participate
Working Groups
Test assets' editors (locations, datapools etc) allow save with empty internal names. This is deemed as bad user experience by customers. Description copied from original Hyades defect #61164: Create a new location by entering .location as the filename 2) Enter a name of "foo" in the name field 3) Close the location 4) Reopen the location 5) Edit the name field by deleting all characters, save and close 6) Create a new datapool with filename foo.datapool and name "temp" 7) Save and close datapool 8) Open foo.datapool 9) Edit the datapool name field by deleting all characters "temp", save and close. The ability to have an empty-named artifact is illogical and confusing to the user.
I think this is for Jerome.
ACTION ITEM: Please target to 4.4 and review the priority according to http://www.eclipse.org/tptp/home/documents/process/development/bugzilla.html by the end of 4.3 i3 (Friday, November 3, 2006).
I agree that the empty name in test navigator is confusing. I can see two separate approaches to address this issue: - avoid empty name by validation of wizard *and* editor. - replace empty name bysomething like "<no-name>" First one is much more complex than second one, this consists to disable the save of an asset if its name field is empty. I don't think that the name field is mandatory from a model prespective so this is not illogical to align UI capabilities to model ones. Empty names are only a visibility problem and this can only occur following user decision. For this reason I would rather consider to put a substitution name instead of empty name. Would we discuss this problem during a future test meeting ?
*** Bug 163978 has been marked as a duplicate of this bug. ***
I am concerned about having empty names, because those names are used in test generation for naming java classes.
*** Bug 91411 has been marked as a duplicate of this bug. ***
Targeting to future since not containable in 4.4.
As discussed on this week's Test Project call (January 22, 2007), the Test Project will focus on existing P1 - P2/Blocker - Major and P1/Normal and test creation/automation defects (omitting defects dependant on outstanding features) in TPTP 4.4. All other Test Project defects have been targeted to future. If this defect has been targeted to future and you/originator feel it should be completed in 4.4, please provide the necessary reason as a reply to this comment or a post to the Test Project mailing list (tptp-test-tooling-dev@eclipse.org). We will collectively triage and assess our resources to determine a case-by-case decision.
Correction: The Test Project mailing list is tptp-testing-tools-dev@eclipse.org.
There is a related defect (something about invalid characters in resources names) which had been fixed. The class LocationValidator is supposed to be public in 4.4 (it is internal now). In RPT editor, I am using this class to make sure the name is valid. Other TPTP editors should do the same.
Jerome, please provide a sizing.
Bulk update of the target field to reflect the change in iteration numbers.
Deferring to I6.
When a logical name is empty (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=160485), it should default to the file name, minus the file extension, since this is the default behavior used in the wizards.
changes introduced with 166025 resolution : . rename via contextual menu makes a name check (ok stay greyed if check fail). also, it changes both logical and physical name . rename via editor makes a name check (resource is not saved and stay in dirty mode at save time if check fail). it only changes logical name name chek policy (more detailled in doc attached to 166025) : 1. name can't be empty 2. name can't be the same as an existing physical resource 3. name can't be the same as an existing logical resource 4. name have to be changed (contextual menu only) example : let's say we have a location named "A.location", with logical name equal to "C", and another location named "B.location" with logical name equal to "B" . in case of renaming of "B" via contextual menu (physical rename) : - if entered name is empty (rule 1), equal to "A" (rule 2), equal to "C" (rule 3) or equal to "B" (rule 4), the OK button stay greyed - any other name is allowed. example : rename to "D" will give "D.location" as physical name and "D" as logical one . in case of renaming of "B" inside the editor (logical rename only) : - if entered name is empty (rule 1), equal to "A" (rule 2), equal to "C" (rule 3), an error message appear at save time, save is not performed and editor stay into "dirty" state - any other name is allowed. example : rename to "D" will give "B.location" as physical name (unchanged) and "D" as logical one all of this should cover the problem of empty logical name for datapools/locations
Resolved by defect https://bugs.eclipse.org/bugs/show_bug.cgi?id=166025.
Closing by default since not closed by the originator in the 7+ months since being resolved. Please reopen if the issue is still present in the latest TPTP release or the resolution is not correct.
