Bug 161932 - Use of internal packages in wsdm tooling tech preview
Summary: Use of internal packages in wsdm tooling tech preview
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP.monitoring (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 critical (vote)
Target Milestone: ---   Edit
Assignee: Andrew Eberbach CLA
QA Contact: Bhanu Prathap V CLA
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2006-10-23 08:30 EDT by Balan Subramanian CLA
Modified: 2010-06-03 15:03 EDT (History)
4 users (show)

See Also:

Attachments
Scan report on 4.3 i2 build showing internal packages being used and where (5.00 KB, text/plain)
2006-10-23 08:33 EDT, Balan Subramanian CLA 		no flags Details
Patch for Capability Plugin (10.18 KB, patch)
2006-12-27 06:20 EST, Saurabh Dravid CLA 		no flags Details | Diff
Patch for removing references from CodeGeneration UI in MRT (11.82 KB, patch)
2007-01-18 04:56 EST, Nalini V CLA 		no flags Details | Diff
Patch for DD plugin (85.62 KB, patch)
2007-01-18 10:31 EST, Saurabh Dravid CLA 		no flags Details | Diff
Patch for removing QName and XMLDuration internal apis (784.29 KB, patch)
2007-01-20 08:37 EST, Saurabh Dravid CLA 		no flags Details | Diff
JUnit patch (340.61 KB, patch)
2007-01-25 00:20 EST, Saurabh Dravid CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balan Subramanian CLA 2006-10-23 08:30:16 EDT 
The API scanner turned up usage of internal packages from the Eclipse platform, the EMF project and WTP. 

All these violations are in the WSDM tooling editors that are part of Tech preview.

org.eclipse.emf.ecore.xml.type.internal.QName
org.eclipse.wst.wsdl.internal.util.WSDLResourceFactoryImpl (must be replaced with WSDLResourceFactory)
org.eclipse.jdt.internal.ui.dialogs.StatusInfo
org.eclipse.emf.ecore.xml.type.internal.XMLDuration
org.eclipse.wst.wsdl.internal.impl.DefinitionImpl
org.eclipse.wst.wsdl.internal.impl.InputImpl
org.eclipse.wst.wsdl.internal.impl.OutputImpl
org.eclipse.ui.internal.ide.IDEWorkbenchMessages
org.eclipse.ui.internal.ide.dialogs.FileSystemSelectionArea
org.eclipse.ui.internal.ide.dialogs.IDEResourceInfoUtils
org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea
org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea.IErrorMessageReporter
org.eclipse.ui.internal.ide.filesystem.FileSystemConfiguration
org.eclipse.ui.internal.ide.filesystem.FileSystemSupportRegistry
org.eclipse.jst.j2ee.internal.web.archive.operations.WebFacetProjectCreationDataModelProvider
org.eclipse.wst.common.componentcore.internal.util.IModuleConstants;
org.eclipse.wst.validation.internal.operations.ValidatorManager;

See attached file for report.
Comment 1 Balan Subramanian CLA 2006-10-23 08:31:17 EDT 
Some of these can be fixed by minor code changes and will need to be done for 4.3. The ones that cannot be addressed by simple code changes will be taken up with the respective projects to be made available as non-internal packages/classes.
Comment 2 Balan Subramanian CLA 2006-10-23 08:33:40 EDT 
Created attachment 52511 [details]
Scan report on 4.3 i2 build showing internal packages being used and where
Comment 3 Dave Smith CLA 2006-10-23 16:31:10 EDT 
Increasing priority as it needs to be addressed before 4.3 release.
Comment 4 Dave Smith CLA 2006-11-06 03:35:20 EST 
Deferring this to 4.4 as it cannot be contained in 4.3 and it only applies to Tech Preview code.  This deferral was approved by the PG on 11/03/2006.
Comment 5 Saurabh Dravid CLA 2006-12-27 06:20:17 EST 
Created attachment 56198 [details]
Patch for Capability Plugin

Please apply this patch.
This patch will remove some internal references to other projects from Capability plugin.
Comment 6 Andrew Eberbach CLA 2006-12-27 10:53:56 EST 
applied patch
Comment 7 Balan Subramanian CLA 2007-01-05 08:34:01 EST 
The following internal packages are still being used as of 01/05/07:

org.eclipse.emf.ecore.xml.type.internal.QName;
org.eclipse.emf.ecore.xml.type.internal.XMLDuration;

org.eclipse.ui.internal.ide.IDEWorkbenchMessages;
org.eclipse.ui.internal.ide.dialogs.FileSystemSelectionArea;
org.eclipse.ui.internal.ide.dialogs.IDEResourceInfoUtils;
org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea;
org.eclipse.ui.internal.ide.dialogs.ProjectContentsLocationArea.IErrorMessageReporter;
org.eclipse.ui.internal.ide.filesystem.FileSystemConfiguration;
org.eclipse.ui.internal.ide.filesystem.FileSystemSupportRegistry;

org.eclipse.jst.j2ee.internal.web.archive.operations.WebFacetProjectCreationDataModelProvider;
org.eclipse.wst.common.componentcore.internal.util.IModuleConstants;
org.eclipse.wst.validation.internal.operations.ValidatorManager;
Comment 8 Andrew Eberbach CLA 2007-01-11 09:20:38 EST 
We should move the writing of muse.xml files to use the new Muse code: http://issues.apache.org/jira/browse/MUSE-169
Comment 9 Dave Smith CLA 2007-01-17 15:50:08 EST 
This needs to be completed in iteration 1
Comment 10 Nalini V CLA 2007-01-18 04:56:36 EST 
Created attachment 57069 [details]
Patch for removing references from CodeGeneration UI in MRT
Comment 11 Saurabh Dravid CLA 2007-01-18 10:31:42 EST 
Created attachment 57084 [details]
Patch for DD plugin

Please apply this patch.
This patch will remove the internal api references form DD and MRT plugins.
Comment 12 Saurabh Dravid CLA 2007-01-20 08:37:01 EST 
Created attachment 57207 [details]
Patch for removing QName and XMLDuration internal apis

Please apply this patch.
This patch will remove the dependency on Internal QName and XMLDuration apis.
Comment 13 Saurabh Dravid CLA 2007-01-25 00:20:20 EST 
Created attachment 57493 [details]
JUnit patch

Please apply this patch.
This patch contains the changes for capability JUnit.
Comment 14 Balan Subramanian CLA 2007-02-08 09:18:37 EST 
All patches applied until 2007-01-25
Comment 15 Balan Subramanian CLA 2007-03-23 00:24:15 EDT 
QA please verify
Comment 16 Bhanu Prathap V CLA 2007-05-03 06:23:58 EDT 
No classes any thing related to tooling and max 
Verified - fixed
Build: TPTP-4.4.0-200705021157
Comment 17 Bhanu Prathap V CLA 2007-05-03 06:24:08 EDT 
Verified - fixed
Build: TPTP-4.4.0-200705021157